feat: Adding screenshot #30597

CBID2 · 2023-12-12T01:15:01Z

Why:

This PR adds a screenshot of checkbox in the "Allowing changes to a pull request branch created from a fork" tutorial. This would help readers know where to grant maintainers edit access when making pull requests for open source projects.

Closes:

Closes #30407

What's being changed (if available, include any code snippets, screenshots, or gifs):

A screenshot is being added.

Check off the following:

I have reviewed my changes in staging, available via the View deployment link in this PR's timeline.
- For content changes, you will also see an automatically generated comment with links directly to pages you've modified. The comment won't appear if your PR only edits files in the data directory.
For content changes, I have completed the self-review checklist.

github-actions · 2023-12-12T01:21:49Z

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.

Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source	Preview	Production	What Changed
`pull-requests/collaborating-with-pull-requests/working-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork.md`	fpt ghec ghes@ 3.11 3.10 3.9 3.8 3.7 ghae	fpt ghec ghes@ 3.11 3.10 3.9 3.8 3.7 ghae

fpt: Free, Pro, Team
ghec: GitHub Enterprise Cloud
ghes: GitHub Enterprise Server
ghae: GitHub AE

nguyenalex836 · 2023-12-12T18:52:43Z

@CBID2 Thanks so much for opening a PR! I'll get this triaged for review ✨

mchammer01

@CBID2 👋🏻 - thanks for improving our docs ✨
Made a few comments and will see if I can provide you with the screenshot.

...requests/working-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork.md

…-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork.md

mchammer01 · 2023-12-15T09:36:15Z

@CBID2 👋🏻 - I'd like to check out your branch to remove your screenshot and add mine, and I don't appear to be able to do it. Can you allow me to check out your branch?

CBID2 · 2023-12-15T12:32:57Z

@CBID2 👋🏻 - I'd like to check out your branch to remove your screenshot and add mine, and I don't appear to be able to do it. Can you allow me to check out your branch?

Hi @mchammer01! :) Sure you can checkout my branch. How do I grant you access?

mchammer01 · 2023-12-15T14:01:14Z

@CBID2 - do you work locally? Have you pushed your branch to the remote?

CBID2 · 2023-12-15T14:16:31Z

@CBID2 - do you work locally? Have you pushed your branch to the remote?

@mchammer01, I used Gitpod to make this PR. How about you post your screenshot in the comment section here and I can replace it myself?

...requests/working-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork.md

…-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork.md

...requests/working-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork.md

…-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork.md

mchammer01 · 2023-12-15T16:35:59Z

@CBID2 - I tried to check out your branch but got into some issues 😞
I made a couple more updates to the PR via the UI.

Can you delete the old screenshot (assets/images/help/pull_requests/checkbox-for-pull-request-edit-access.png) in your PR, and add this screenshot instead, to the same location (note that the name of the new screenshot is different, and that I already updated the reference to it in the article):

The new name is allow-edits-and-access-by-maintainers.png

CBID2 · 2023-12-15T21:53:24Z

@CBID2 - I tried to check out your branch but got into some issues 😞 I made a couple more updates to the PR via the UI.

Can you delete the old screenshot (assets/images/help/pull_requests/checkbox-for-pull-request-edit-access.png) in your PR, and add this screenshot instead, to the same location (note that the name of the new screenshot is different, and that I already updated the reference to it in the article):

The new name is allow-edits-and-access-by-maintainers.png

Hi @mchammer01! :) I changed the screenshot like you requested! :)

...requests/working-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork.md

…-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork.md

mchammer01

Thanks for your patience @CBID2, and for adding the screenshot 💖
This LGTM

CBID2 · 2023-12-16T15:53:26Z

Thanks for your patience @CBID2, and for adding the screenshot 💖

This LGTM

Anytime @mchammer01! :)

github-actions · 2023-12-16T16:01:38Z

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡

jakirkham · 2023-12-16T22:00:21Z

Thanks all! 🙏

This looks great 😀

CBID2 · 2023-12-17T02:54:57Z

Thanks all! 🙏

This looks great 😀

Anytime @jakirkham! :)

CBID2 added 2 commits December 12, 2023 01:06

feat: add screenshot

f3af3a3

feat: hyperlink screenshot

23882d4

github-actions bot added the triage Do not begin working on this issue until triaged by the team label Dec 12, 2023

Merge branch 'main' into adding-screenshot

74ad2fd

CBID2 mentioned this pull request Dec 12, 2023

Adding screenshot of checkbox in "Allowing changes to a pull request branch created from a fork" #30407

Closed

1 task

Merge branch 'main' into adding-screenshot

2bb16e4

Merge branch 'main' into adding-screenshot

2daabbd

mchammer01 reviewed Dec 15, 2023

View reviewed changes

...requests/working-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork.md Outdated Show resolved Hide resolved

...requests/working-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork.md Outdated Show resolved Hide resolved

Update content/pull-requests/collaborating-with-pull-requests/working…

719070d

…-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork.md

Merge branch 'main' into adding-screenshot

2ef527a

Merge branch 'main' into adding-screenshot

4df7aee

Merge branch 'main' into adding-screenshot

f017989

mchammer01 reviewed Dec 15, 2023

View reviewed changes

...requests/working-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork.md Outdated Show resolved Hide resolved

Update content/pull-requests/collaborating-with-pull-requests/working…

04e907a

…-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork.md

mchammer01 reviewed Dec 15, 2023

View reviewed changes

...requests/working-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork.md Outdated Show resolved Hide resolved

Update content/pull-requests/collaborating-with-pull-requests/working…

4d17b30

…-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork.md

Merge branch 'main' into adding-screenshot

2d8a666

fix: replace my screenshot with one made by maintainer

b5a80f4

mchammer01 reviewed Dec 16, 2023

View reviewed changes

...requests/working-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork.md Outdated Show resolved Hide resolved

Update content/pull-requests/collaborating-with-pull-requests/working…

aba43db

…-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork.md

mchammer01 approved these changes Dec 16, 2023

View reviewed changes

mchammer01 enabled auto-merge December 16, 2023 15:52

mchammer01 added this pull request to the merge queue Dec 16, 2023

Merged via the queue into github:main with commit 668798e Dec 16, 2023

CBID2 deleted the adding-screenshot branch December 16, 2023 16:16

feat: Adding screenshot #30597

feat: Adding screenshot #30597

Uh oh!

Conversation

CBID2 commented Dec 12, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Why:

Closes:

What's being changed (if available, include any code snippets, screenshots, or gifs):

Check off the following:

Uh oh!

github-actions bot commented Dec 12, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automatically generated comment ℹ️

Content directory changes

Uh oh!

nguyenalex836 commented Dec 12, 2023

Uh oh!

mchammer01 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

mchammer01 commented Dec 15, 2023

Uh oh!

CBID2 commented Dec 15, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mchammer01 commented Dec 15, 2023

Uh oh!

CBID2 commented Dec 15, 2023

Uh oh!

Uh oh!

Uh oh!

mchammer01 commented Dec 15, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

CBID2 commented Dec 15, 2023

Uh oh!

Uh oh!

mchammer01 left a comment

Choose a reason for hiding this comment

Uh oh!

CBID2 commented Dec 16, 2023

Uh oh!

github-actions bot commented Dec 16, 2023

Uh oh!

jakirkham commented Dec 16, 2023

Uh oh!

CBID2 commented Dec 17, 2023

Uh oh!

Uh oh!

CBID2 commented Dec 12, 2023 •

edited

Loading

github-actions bot commented Dec 12, 2023 •

edited

Loading

CBID2 commented Dec 15, 2023 •

edited

Loading

mchammer01 commented Dec 15, 2023 •

edited

Loading