-
Notifications
You must be signed in to change notification settings - Fork 59.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify Git LFS installation and verification steps #34314
Clarify Git LFS installation and verification steps #34314
Conversation
Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines. |
Automatically generated comment ℹ️This comment is automatically generated and will be overwritten every time changes are committed to this branch. The table contains an overview of files in the Content directory changesYou may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.
fpt: Free, Pro, Team |
@kdotmanoj Thank you for opening a PR ✨ @aledefault Given our conversation in the linked issue, we wanted to give you chance to review this PR 💛 please feel free to ping here once you are finished reviewing! CC @subatoi |
In my opinion, I'll keep it as close, if not literal to this @subatoi comment. In addition to that, not only the Linux version should be updated, also Mac (there are more than one installation method) and Windows (if needed) as well. By the way, there is already a .md talking about "lfs installation verification". It could be interesting to keep the verification quite similar to that. Sorry I can't be more helpful. I'm on my smartphone with no access to a laptop. |
I agree with @aledefault — I misspoke slightly when I singled out line 116. Whilst line 116 does need to change, we also need to change line 48 for macOS. In both these cases I'd keep it to the one-line change:
In the case of Windows, I think we should leave it as it is, as it's technically correct and users are likely to have a range of different configurations—but I'm very open to discussing that. We could certainly add a reference to the reusable @aledefault mentioned after this new change, so that could go in this PR or a separate one. |
Thanks @aledefault & @subatoi for your input! |
@kdotmanoj Thank you for making that update to your PR! ✨ I'll update the branch and get this merged once tests are passing 🍏 |
Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡ |
Why:
Closes: #34292
What's being changed (if available, include any code snippets, screenshots, or gifs):
git lfs version
.Check off the following: