-
Notifications
You must be signed in to change notification settings - Fork 62.9k
Clarify what gitignore templates are/do #39813
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
How to review these changes 👓Thank you for your contribution. To review these changes, choose one of the following options: A Hubber will need to deploy your changes internally to review. Table of review linksNote: Please update the URL for your staging server or codespace. The table shows the files in the
Key: fpt: Free, Pro, Team; ghec: GitHub Enterprise Cloud; ghes: GitHub Enterprise Server 🤖 This comment is automatically generated. |
@Sharra-writes I see CI is still quite unhappy. Are the |
@jsoref Our engineers are working to figure out the CI problems. It's a doc specific problem, which had everyone stumped for a bit, since docs and docs-internal are synced. Even though I trust you to know what you're talking about, I should probably run your wording by the relevant engineering team anyway to see if they have nitpicks. Hopefully all the checks will be fixed by the time they get back to me. 🤞 Edit: Right, review links. I don't actually know, because I was still very much being trained when that was removed, and no one explained it to me. 😅 |
Oh, I only know what words mean. I can't claim to understand if the changes I'm making are desirable/agreeable to GitHub. Take your time. microsoft/playwright#12487 (comment)
-import { Page, test as Test } from '@playwright/test'
+import { type Page, test as Test } from '@playwright/test' I know enough not to bother making a PR for this stuff. |
Why:
Creating a new repository
doesn't mention gitignore templates #39758What's being changed (if available, include any code snippets, screenshots, or gifs):
Check off the following: