Skip to content

Conversation

matiboux
Copy link

@matiboux matiboux commented Sep 16, 2025

Why:

Closes: #40391

What's being changed (if available, include any code snippets, screenshots, or gifs):

This updates the allowed contexts for jobs.<job_id>.secrets.<secret_id> and jobs.<job_id>.with.<input_id> in reusable-workflows.md to match the actual behavior and the documentation in contexts.md. This adds strategy, matrix, inputs, and vars to the allowed contexts for these keys, ensuring consistency.

This also renames placeholders in workflow keys in contexts.md to match those used in reusable-workflows.md, replacing <secrets_id> with <secret_id> and <with_id> with <input_id> for consistency.

Please verify that these changes are correct and align with the intended functionality and actual behavior of GitHub Actions.

Check off the following:

  • A subject matter expert (SME) has reviewed the technical accuracy of the content in this PR. In most cases, the author can be the SME. Open source contributions may require an SME review from GitHub staff.
  • The changes in this PR meet the docs fundamentals that are required for all content.
  • All CI checks are passing and the changes look good in the review environment.

@Copilot Copilot AI review requested due to automatic review settings September 16, 2025 09:26
Copy link

welcome bot commented Sep 16, 2025

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes inconsistencies in the allowed contexts documentation for reusable workflow secrets and inputs in the contexts reference. It updates the allowed contexts for jobs.<job_id>.secrets.<secret_id> and jobs.<job_id>.with.<input_id> to match their actual behavior and align with the documentation in reusable-workflows.md.

Key changes:

  • Removes vars, inputs, strategy, and matrix from allowed contexts for workflow secrets and inputs
  • Renames parameter placeholders for consistency: <secrets_id> to <secret_id> and <with_id> to <input_id>

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Sep 16, 2025
Copy link
Contributor

github-actions bot commented Sep 16, 2025

How to review these changes 👓

Thank you for your contribution. To review these changes, choose one of the following options:

A Hubber will need to deploy your changes internally to review.

Table of review links

Note: Please update the URL for your staging server or codespace.

The table shows the files in the content directory that were changed in this pull request. This helps you review your changes on a staging server. Changes to the data directory are not included in this table.

Source Review Production What Changed
actions/reference/workflows-and-actions/contexts.md fpt
ghec
ghes@ 3.17 3.16 3.15 3.14
fpt
ghec
ghes@ 3.17 3.16 3.15 3.14
actions/reference/workflows-and-actions/workflow-syntax.md fpt
ghec
ghes@ 3.17 3.16 3.15 3.14
fpt
ghec
ghes@ 3.17 3.16 3.15 3.14

Key: fpt: Free, Pro, Team; ghec: GitHub Enterprise Cloud; ghes: GitHub Enterprise Server

🤖 This comment is automatically generated.

@matiboux matiboux force-pushed the 40391-fix-jobs-secrets-context branch from 2883ead to dac15a9 Compare September 16, 2025 11:07
@matiboux
Copy link
Author

Following new testing, this PR has been updated to consider the allowed expression contexts from contexts.md as the source of truth and resolve inconsistencies accordingly.

@matiboux matiboux requested a review from Copilot September 16, 2025 11:14
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

@Sharra-writes Sharra-writes added content This issue or pull request belongs to the Docs Content team github_actions Pull requests that update GitHub Actions code and removed triage Do not begin working on this issue until triaged by the team labels Sep 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content This issue or pull request belongs to the Docs Content team github_actions Pull requests that update GitHub Actions code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistent allowed contexts for reusable workflow secrets/inputs
2 participants