-
Notifications
You must be signed in to change notification settings - Fork 63.3k
Fix allowed contexts for reusable workflow secrets/inputs #40392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes inconsistencies in the allowed contexts documentation for reusable workflow secrets and inputs in the contexts reference. It updates the allowed contexts for jobs.<job_id>.secrets.<secret_id>
and jobs.<job_id>.with.<input_id>
to match their actual behavior and align with the documentation in reusable-workflows.md
.
Key changes:
- Removes
vars
,inputs
,strategy
, andmatrix
from allowed contexts for workflow secrets and inputs - Renames parameter placeholders for consistency:
<secrets_id>
to<secret_id>
and<with_id>
to<input_id>
How to review these changes 👓Thank you for your contribution. To review these changes, choose one of the following options: A Hubber will need to deploy your changes internally to review. Table of review linksNote: Please update the URL for your staging server or codespace. The table shows the files in the
Key: fpt: Free, Pro, Team; ghec: GitHub Enterprise Cloud; ghes: GitHub Enterprise Server 🤖 This comment is automatically generated. |
2883ead
to
dac15a9
Compare
Following new testing, this PR has been updated to consider the allowed expression contexts from |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
Why:
Closes: #40391
What's being changed (if available, include any code snippets, screenshots, or gifs):
This updates the allowed contexts for
jobs.<job_id>.secrets.<secret_id>
andjobs.<job_id>.with.<input_id>
inreusable-workflows.md
to match the actual behavior and the documentation incontexts.md
. This addsstrategy
,matrix
,inputs
, andvars
to the allowed contexts for these keys, ensuring consistency.This also renames placeholders in workflow keys in
contexts.md
to match those used inreusable-workflows.md
, replacing<secrets_id>
with<secret_id>
and<with_id>
with<input_id>
for consistency.Please verify that these changes are correct and align with the intended functionality and actual behavior of GitHub Actions.
Check off the following: