-
Notifications
You must be signed in to change notification settings - Fork 63.6k
Adds a Images section to Basic Writing and Formatting Syntax #8982
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@thispsj |
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking great 💖
I've suggested changes to tidy up the spacing in the table and expand "&" and "repo" to the full words. Otherwise, this looks ready to merge now. Thanks for your patience.
...getting-started-with-writing-and-formatting-on-github/basic-writing-and-formatting-syntax.md
Outdated
Show resolved
Hide resolved
...getting-started-with-writing-and-formatting-on-github/basic-writing-and-formatting-syntax.md
Outdated
Show resolved
Hide resolved
...getting-started-with-writing-and-formatting-on-github/basic-writing-and-formatting-syntax.md
Outdated
Show resolved
Hide resolved
...getting-started-with-writing-and-formatting-on-github/basic-writing-and-formatting-syntax.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@thispsj - thanks for the further updates.
This looks ready to merge 💖
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@thispsj Thanks so much for opening a PR with this fix! I'll update the branch and get this merged once tests are passing 🍏
Thanks a bunch for contributing to the GitHub docs ✨ Your efforts, patience and time are greatly appreciated 🐬
@thispsj Can you enable the checkbox to allow maintainer edits? Then I'll be able to hit the update button and get this merged in 😄. https://docs.github.com/en/github/collaborating-with-issues-and-pull-requests/allowing-changes-to-a-pull-request-branch-created-from-a-fork |
@ramyaparimi done. P.S: You don't need to press the Update Branch button. (My action does that automatically whenever Octomerger or someone else pushes to main) |
Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡ |
Why:
Closes #8964
What's being changed:
Adds images section to this article
Check off the following: