Skip to content

Conversation

thispsj
Copy link
Contributor

@thispsj thispsj commented Aug 12, 2021

Why:

Closes #8964

What's being changed:

Adds images section to this article

Check off the following:

  • I have reviewed my changes in staging (look for the latest deployment event in your pull request's timeline, then click View deployment).
  • For content changes, I have completed the self-review checklist.

@ghost ghost temporarily deployed to docs-8982--add-relimgs August 12, 2021 07:42 Inactive
@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Aug 12, 2021
@ghost ghost temporarily deployed to docs-8982--add-relimgs August 12, 2021 08:23 Inactive
@ramyaparimi
Copy link
Contributor

@thispsj
Thanks so much for opening a PR! I'll get this triaged for review ⚡

@ramyaparimi ramyaparimi added content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review and removed triage Do not begin working on this issue until triaged by the team labels Aug 12, 2021
@ghost ghost temporarily deployed to docs-8982--add-relimgs August 12, 2021 14:06 Inactive
@ghost ghost temporarily deployed to docs-8982--add-relimgs August 12, 2021 16:30 Inactive
@ghost ghost temporarily deployed to docs-8982--add-relimgs August 12, 2021 16:53 Inactive
@ghost ghost temporarily deployed to docs-8982--add-relimgs August 13, 2021 04:52 Inactive
@ghost ghost temporarily deployed to docs-8982--add-relimgs August 13, 2021 04:53 Inactive
@ghost ghost temporarily deployed to docs-8982--add-relimgs August 13, 2021 07:46 Inactive
@ghost ghost temporarily deployed to docs-8982--add-relimgs August 13, 2021 13:53 Inactive
@Zringgo77

This comment has been minimized.

@ghost ghost temporarily deployed to docs-8982--add-relimgs August 14, 2021 05:18 Inactive
@ghost ghost temporarily deployed to docs-8982--add-relimgs August 14, 2021 05:31 Inactive
Copy link
Contributor

@felicitymay felicitymay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking great 💖
I've suggested changes to tidy up the spacing in the table and expand "&" and "repo" to the full words. Otherwise, this looks ready to merge now. Thanks for your patience.

@thispsj thispsj requested a review from felicitymay August 23, 2021 14:19
Copy link
Contributor

@felicitymay felicitymay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thispsj - thanks for the further updates.

This looks ready to merge 💖

Copy link
Contributor

@ramyaparimi ramyaparimi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thispsj Thanks so much for opening a PR with this fix! I'll update the branch and get this merged once tests are passing 🍏

Thanks a bunch for contributing to the GitHub docs ✨ Your efforts, patience and time are greatly appreciated 🐬

@ramyaparimi
Copy link
Contributor

@thispsj Can you enable the checkbox to allow maintainer edits? Then I'll be able to hit the update button and get this merged in 😄. https://docs.github.com/en/github/collaborating-with-issues-and-pull-requests/allowing-changes-to-a-pull-request-branch-created-from-a-fork

@thispsj
Copy link
Contributor Author

thispsj commented Aug 23, 2021

@ramyaparimi done.

P.S: You don't need to press the Update Branch button. (My action does that automatically whenever Octomerger or someone else pushes to main)

@ramyaparimi ramyaparimi enabled auto-merge (squash) August 23, 2021 14:47
@ramyaparimi ramyaparimi merged commit 1a79800 into github:main Aug 23, 2021
@github-actions
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues

@thispsj thispsj deleted the add-relimgs branch August 23, 2021 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add details of how to embed images
6 participants