Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ruff to clean code linters #4283

Merged
merged 3 commits into from
May 5, 2024
Merged

add ruff to clean code linters #4283

merged 3 commits into from
May 5, 2024

Conversation

keksiqc
Copy link
Contributor

@keksiqc keksiqc commented Apr 23, 2024

An extremely fast Python linter, written in Rust.

Please confirm this pull request meets the following requirements:

Which change are you proposing?

  • Suggesting edits to an existing topic or collection
  • Curating a new topic or collection
  • Something that does not neatly fit into the binary options above

Editing an existing topic or collection

I'm suggesting these edits to an existing topic or collection:

  • Image (and my file is *.png, square, dimensions 288x288, size <= 75 kB)
  • Content (and my changes are in index.md)

Ruff is an extremely fast Python linter, that replaces flake8, black and more.


Please note: we will close your PR without comment if you do not check the boxes above and provide ALL requested information.

An extremely fast Python linter, written in Rust.
@keksiqc keksiqc requested a review from a team as a code owner April 23, 2024 16:54
Copy link
Contributor

@kenyonj kenyonj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution! Currently we are only accepting additions to collection lists with the new item appended to the end of the list. Please make this change and we can merge it in 😄 .

@keksiqc
Copy link
Contributor Author

keksiqc commented Apr 27, 2024

Thank you for your contribution! Currently we are only accepting additions to collection lists with the new item appended to the end of the list. Please make this change and we can merge it in 😄 .

Sure thing! I made the necessary adjustments and added the new item to the end of the list.

Copy link
Contributor

@ahpook ahpook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ahpook ahpook enabled auto-merge May 3, 2024 00:26
@ahpook ahpook disabled auto-merge May 5, 2024 16:10
@ahpook ahpook merged commit f941f98 into github:main May 5, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants