[terminal-stylist] Terminal Stylist report: console output consistency in pkg/ (Go)

[github-actions[bot]]

Overview

Scanned 1,936 non-test .go files under pkg/ (_test.go skipped, pkg/linters testdata fixtures excluded because they intentionally contain raw fmt.Print calls). Serena was activated (go, typescript, bash language servers) and used for reference checks.

The console layer is in good shape. Huh forms, the adaptive palette, and TTY and environment detection are centralized. The gaps are a few NO_COLOR bypass paths, doubled status markers, and a large verbose-logging pattern that should use console.LogVerbose.

Key metrics

Area	Measure
Explicit fmt.Fprint to os.Stderr or os.Stdout outside pkg/console	about 2,700 calls, about 1,870 single-line calls use a console helper
Raw verbose-gated stderr writes	about 475 (approximate)
Verbose blocks replaceable by console.LogVerbose	55 (LogVerbose has only 44 call sites)
pkg/workflow stderr writes	167, of which 149 (89%) use formatCompilerMessage or console
Hard-coded color literals outside pkg/styles	0
Direct NO_COLOR or TERM reads outside console, colorwriter, styles	0
Huh field builders in pkg/cli	about 19, all wrapped by console form constructors

Top findings

1. NO_COLOR bypass in RenderErrorBox (medium). The TTY branch (pkg/console/console.go:525) returns lipgloss ANSI with no colorwriter.Degrade. Callers print each line straight to os.Stderr: pkg/cli/deps_security.go:96, pkg/cli/mcp_inspect_mcp.go:68 and :80. The package contract in applyStyle says rendered ANSI must pass through the color-profile writer. This is based on code reading, not a runtime check. The TTY branches of RenderTitleBox, RenderErrorBox, and RenderInfoSection call tty.IsStderrTerminal() directly, so they cannot be injected and no test exercises them.
2. Doubled status markers (7 sites). pkg/cli/mcp_inspect_mcp.go:90 and :673 pass a check-mark emoji into PrintSuccessMessage, which renders as a success mark followed by the emoji. pkg/workflow/npm_validation.go:102, pip_validation.go:110 and :268, and agent_validation.go:449 pass a check mark into FormatInfoMessage, which renders as the info marker followed by a check mark. pkg/cli/mcp_validation.go:171 passes a cross into FormatWarningMessage.
3. Verbose logging bypasses LogVerbose (medium). 55 blocks match exactly if verbose followed by a FormatVerboseMessage write to os.Stderr. The heaviest files are logs_metrics.go, dispatch.go, pr_command.go, and run_push.go. pkg/workflow/claude_logs.go has similar raw writes.
4. Compiler warnings use raw strings and three casings (low to medium). 18 of 167 pkg/workflow stderr writes bypass formatCompilerMessage. Examples: compiler_orchestrator_engine.go:320 (WARNING:), cache_steps.go:24 (Warning:). Literal prefix counts are Warning: 123, WARNING: 22, warning: 2.
5. Two symbol vocabularies (low). The console uses check, cross, warning, bullet, and arrow glyphs. Production code also uses emoji such as check-mark-button, cross-mark, and red circle (43 lines). The MCP work-queue TUI uses an ASCII border while console boxes use Unicode rounded borders. Confirm whether that is intentional.
6. Unused or redundant console API (low). Eight *Stdout formatters have zero production callers: FormatErrorStdout, FormatSuccessMessageStdout, FormatWarningMessageStdout, FormatCommandMessageStdout, FormatProgressMessageStdout, FormatPromptMessageStdout, FormatVerboseMessageStdout, FormatListItemStdout. The RenderTableStderr alias is also unused. WASM stubs in destination_stdout_wasm.go mirror them, so remove both sides together. Each *Stderr alias duplicates its bare form (FormatInfoMessage has 694 uses, FormatInfoMessageStderr has 78). Three error formatters have confusing names: FormatError, FormatErrorStderr, FormatErrorMessage.
7. Unused styles and a divergent error box (low). Count, Location, ListHeader, ServerType, ErrorBox, NormalBorder, and ThickBorder have no production references. Serena find_referencing_symbols shows only test and README references. styles.ErrorBox is unused, while RenderErrorBox builds its own style inline. TestErrorBoxUsesCentralizedBorder tests a box that production never renders. The theme.go package doc (line 40) recommends fmt.Println(styles.Error.Render(...)), which skips degrade and TTY handling.
8. Fixed table width (low). DefaultTableWidth is 80 (pkg/console/table_width.go:11). The package never reads the real terminal width, and MaxWidth defaults to 0 (unbounded).
9. Design question: NO_COLOR also enables accessible mode. IsAccessibleMode (pkg/console/accessibility.go:15) returns true for NO_COLOR. That switches Huh to accessible prompts and disables spinners. Confirm whether this coupling is intended.

Strengths to keep

• Every interactive Huh field goes through console.NewForm, NewInputForm, NewSelectForm, or NewConfirmForm, so HuhTheme and WithAccessible apply everywhere.
• Only pkg/styles defines colors, with Light and Dark variants via lipgloss.LightDark.
• TTY detection is centralized in pkg/tty (35 call sites), and color degradation in pkg/colorwriter.
• Data goes to stdout (for example, unstyled Markdown in pkg/cli/audit_diff_render.go) and status goes to stderr.
• Spinners disable themselves on non-TTY or accessible sessions. Raw cursor sequences are isolated in terminal.go with a documented justification.

Recommended next actions

1. Apply colorwriter.Degrade in the RenderErrorBox TTY branch. Add an injectable TTY check so the branch can be tested.
2. Remove the embedded markers and labels from the 7 doubled-marker sites.
3. Migrate the 55 exact verbose blocks to console.LogVerbose. This is a mechanical change suitable for one PR.
4. Route the 18 raw pkg/workflow warnings through formatCompilerMessage, and standardize the prefix casing.
5. Delete the unused Stdout variants and RenderTableStderr together with their WASM stubs. Plan to collapse the *Stderr aliases.
6. Either use styles.ErrorBox in RenderErrorBox or delete it. Remove the other unused style exports and fix the theme.go doc example.
7. Decide the NO_COLOR semantics, and decide whether to read the terminal width instead of hard-coding 80.

Method and limits

Method: ripgrep and awk pattern counts, reading of pkg/console and pkg/styles core files, and Serena activate_project and find_referencing_symbols. Counts are approximate for multi-line calls. The NO_COLOR behavior of Lipgloss was not runtime-verified because the module cache is not populated for offline reads. Linter testdata fixtures and _test.go files were excluded.

References: §42988700920

Generated by 💄 Terminal Stylist · pi · routed: haiku55 xhigh · ~23 AIC · ⌖ ~2 AIC · ⊞ 4.7K · ◷

• expires on Nov 12, 2026, 12:50 AM UTC-08:00

[github-actions[bot]]

This discussion has been marked as outdated by Terminal Stylist.

A newer discussion is available at Discussion #77113.