Skip to content

Conversation

pawamoy
Copy link
Contributor

@pawamoy pawamoy commented Mar 7, 2018

As seen in issue #18, minimum git version required is 2.6.0.

@mhagger
Copy link
Member

mhagger commented Mar 7, 2018

@pawamoy: Thanks for this patch. Did you actually verify that git-sizer runs with v2.6.0? (I.e., are there any newer features that it relies on?) I don't think so, but it would be good to check.

Long term we could ask git what version it is and, if it is less than 2.6.0, could omit the --buffer option (which is only there for efficiency, not correctness).

@pawamoy
Copy link
Contributor Author

pawamoy commented Mar 7, 2018

I did not try with git == 2.6.0 indeed, but latest (2.16.2). Just let me try and I'll come back to tell you!

@pawamoy
Copy link
Contributor Author

pawamoy commented Mar 7, 2018

So I tried with git 2.5.0, 2.5.5 and 2.6.0. Only git 2.6.0 made git-sizer happy.

If git-sizer can support older versions than 2.6.0, then it is even better, and you can close this PR 😄

@mhagger
Copy link
Member

mhagger commented Mar 9, 2018

So I tried with git 2.5.0, 2.5.5 and 2.6.0. Only git 2.6.0 made git-sizer happy.

Awesome, thanks @pawamoy

@mhagger mhagger merged commit 3e1d038 into github:master Mar 9, 2018
@larsxschneider
Copy link
Member

Maybe you could reuse Git LFS code to check the Git version? https://github.com/git-lfs/git-lfs/blob/98288ae18899244501850a92065b207ce18821f7/git/version.go#L32

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants