Skip to content

Conversation

JoannaaKL
Copy link
Contributor

@JoannaaKL JoannaaKL commented Oct 1, 2025

Delete tool that is failing due to schema issues

Failed to validate tool mcp_github_update_project_item: Error: tool parameters array type must have items. Please open a Github issue for the MCP server or extension which provides this tool

Old issue with json array type modelcontextprotocol/modelcontextprotocol#410

@JoannaaKL JoannaaKL requested a review from a team as a code owner October 1, 2025 09:50
@Copilot Copilot AI review requested due to automatic review settings October 1, 2025 09:50
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the update_project_item tool from the GitHub MCP Server, streamlining the project management functionality to focus on add and delete operations only.

  • Removes the UpdateProjectItem function and its registration
  • Removes comprehensive test coverage for the update functionality
  • Updates documentation to reflect the removal

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
pkg/github/tools.go Removes registration of UpdateProjectItem tool from the toolset
pkg/github/projects.go Removes the complete UpdateProjectItem function implementation
pkg/github/projects_test.go Removes all test cases for UpdateProjectItem functionality
go.mod Changes go-querystring dependency from indirect to direct
README.md Removes update_project_item tool documentation

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment on lines 624 to 626
type updateProjectItemOptions struct {
Fields []*newProjectV2Field `json:"fields,omitempty"`
}
Copy link
Preview

Copilot AI Oct 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The updateProjectItemOptions struct is no longer used after removing the UpdateProjectItem function. This struct should be removed to avoid dead code.

See below for a potential fix:


Copilot uses AI. Check for mistakes.

@JoannaaKL JoannaaKL marked this pull request as draft October 1, 2025 09:52
@JoannaaKL JoannaaKL marked this pull request as ready for review October 1, 2025 10:06
@JoannaaKL JoannaaKL merged commit 6d01897 into github:main Oct 1, 2025
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants