Consolidating pull requests get tools
#1172
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to almaleksia/consolidate-pull-requests
There was a problem hiding this comment.
Pull Request Overview
This PR consolidates six separate pull request read tools (get_pull_request, get_pull_request_files, get_pull_request_status, get_pull_request_diff, get_pull_request_reviews, get_pull_request_review_comments) into a single unified tool called pull_request_read that uses a method parameter to determine which specific operation to perform.
Key changes:
- Replaced multiple individual tools with a single consolidated
pull_request_readtool - Added method-based routing with six supported methods:
get,get_files,get_status,get_diff,get_reviews,get_review_comments - Updated all test cases to use the new consolidated tool and include the required
methodparameter
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| pkg/github/tools.go | Updated toolset registration to use single PullRequestRead tool instead of six separate tools |
| pkg/github/pullrequests_test.go | Updated all test cases to use new tool name and include required method parameter |
| pkg/github/pullrequests.go | Consolidated six separate tool functions into one PullRequestRead function with method-based routing |
| pkg/github/toolsnaps/pull_request_read.snap | Added snapshot for new consolidated tool |
| pkg/github/toolsnaps/get_*.snap | Removed snapshots for deprecated individual tools |
| README.md | Updated documentation to reflect new consolidated tool structure |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR consolidates tools
get_pull_requestget_pull_request_filesget_pull_request_statusget_pull_request_diffget_pull_request_reviewsget_pull_request_review_commentsunder
pull_request_readwithmethodargument:getget_filesget_statusget_diffget_reviewsget_review_commentsChange has been evaluated on curated benchmarks and introduced no regressions to the current behavior accross all models.