Skip to content

Conversation

tonytrg
Copy link
Contributor

@tonytrg tonytrg commented Oct 9, 2025

As we named pull_request_read and pull_request_review_write we are sticking to that format as the read write attribute makes more sense as a suffix for better text search and formatting.

And the label_write tool was accidentally added to issues too.

@tonytrg tonytrg requested a review from a team as a code owner October 9, 2025 16:02
@Copilot Copilot AI review requested due to automatic review settings October 9, 2025 16:02
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR renames the WriteLabel function and tool to LabelWrite to improve naming consistency. The change affects both the function name and the tool's identifier.

  • Renamed function from WriteLabel to LabelWrite
  • Updated tool name from "write_label" to "label_write"
  • Updated all references and documentation accordingly

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
pkg/github/tools.go Updated function calls to use new LabelWrite name
pkg/github/labels_test.go Updated test function calls and expected tool name
pkg/github/labels.go Renamed function and updated translation keys
pkg/github/toolsnaps/label_write.snap Updated snapshot with new tool name
README.md Reorganized documentation to reflect new tool name ordering

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment on lines +246 to +248
mcp.WithDescription(t("TOOL_LABEL_WRITE_DESCRIPTION", "Perform write operations on repository labels. To set labels on issues, use the 'update_issue' tool.")),
mcp.WithToolAnnotation(mcp.ToolAnnotation{
Title: t("TOOL_WRITE_LABEL_TITLE", "Write operations on repository labels."),
Title: t("TOOL_LABEL_WRITE_TITLE", "Write operations on repository labels."),
Copy link

Copilot AI Oct 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The translation keys have been updated from TOOL_WRITE_LABEL_* to TOOL_LABEL_WRITE_* but there's no evidence that the corresponding translation files have been updated. This could result in missing translations falling back to the default English text.

Copilot uses AI. Check for mistakes.

@tonytrg tonytrg merged commit f9343e6 into main Oct 9, 2025
16 of 17 checks passed
@tonytrg tonytrg deleted the tonytrg/rename-tools branch October 9, 2025 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants