Key fix #41
Merged
Key fix #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix for bug where we can't use symbols
Co-authored-by: Kristján Oddsson <koddsson@gmail.com>
keithamus
approved these changes
Mar 30, 2021
|
🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a bug when trying to use a symbol like
Control+Shift+`as the hotkey. See https://github.com/github/github/pull/175242#discussion_r603640676Because of this line, ` doesn't have an uppercase value.
I'm trying to fix by checking the
KeyboardEvent.codehttps://developer.mozilla.org/en-US/docs/Web/API/KeyboardEvent/code value for "Key" which should be alpha numeric.