added test for dns failure #7
Closed
+46
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
Adds a test for DNS hostname lookup failure scenarios in the Memcached client. The test verifies that the client properly handles NXDOMAIN responses and server ejection behavior when configured with auto_eject_hosts.
- Added
test_dns_nxdomain_servermethod to test DNS failure handling - Tests server ejection and recovery behavior when DNS lookups fail
- Verifies failover to working servers when one server has DNS issues
| assert_raise(Memcached::HostnameLookupFailure) { cache.get(key2, @value) } | ||
|
|
||
| # Hit second server and pass the limit | ||
| key2 = 'test_missing_server' |
There was a problem hiding this comment.
The variable key2 is redeclared multiple times with the same value. Consider declaring it once at the beginning of the test method to avoid duplication.
Suggested change
| key2 = 'test_missing_server' | |
| key2 = 'test_missing_server' | |
| # Hit second server up to the server_failure_limit | |
| assert_raise(Memcached::HostnameLookupFailure) { cache.set(key2, @value) } | |
| assert_raise(Memcached::HostnameLookupFailure) { cache.get(key2, @value) } | |
| # Hit second server and pass the limit |
Copilot uses AI. Check for mistakes.
| # Hit second server up to the server_failure_limit | ||
| key2 = 'test_missing_server' | ||
| assert_raise(Memcached::HostnameLookupFailure) { cache.set(key2, @value) } | ||
| assert_raise(Memcached::HostnameLookupFailure) { cache.get(key2, @value) } |
There was a problem hiding this comment.
The get method typically doesn't accept a second parameter for the value. This should likely be cache.get(key2) without the @value parameter.
Suggested change
| assert_raise(Memcached::HostnameLookupFailure) { cache.get(key2, @value) } | |
| assert_raise(Memcached::HostnameLookupFailure) { cache.get(key2) } |
Copilot uses AI. Check for mistakes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.