Add type: commonjs
package.json to cjs output
#10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #9, we have both commonJS and esm. When imported from commonjs, it will resolve the cjs files, but it iterprets them as esm because the nearest package.json is
type: module
To fix this, we can add a new
package.json
indist/cjs
with{ "type": "commonjs" }
to hint to node that the code is indeed cjsBig thanks to @calebboyd for pointing this out!