Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace fancy quotes with plain ol' boring quotes #37

Merged
merged 3 commits into from
Aug 18, 2016
Merged

Conversation

bkeepers
Copy link

Fixes #32

  • Replace and with '
  • Replace and with "

@wooorm any thoughts on how to add lint tests for quotes? I tried forking https://github.com/Shopify/retext-shopify and doing replacements, but it wasn't working, so I assume that words get parsed differently than quotes.

@wooorm
Copy link
Contributor

wooorm commented Aug 18, 2016

Yup, what they’re using is especially catered to words!

I’ve got a working version to check for quotes which I’ll publish in a minute (proof below haha)

Want me to add the plugin to GH-40, or create a new one?

P.S. I don’t really like the term “dumb”, so I’m switching it to “straight” vs. “smart” quotes asap.

screen shot 2016-08-18 at 15 26 17

* origin/gh-pages: (33 commits)
  edit contributor agreement section
  make legal.md friendlier sounding
  CC0 for any code
  Add linting for sentence-spacing
  missing <
  cc-by-4.0 content, mit code
  Remove unnecessary pronouns
  fix internal links
  Remove duplicate spaces
  Use Oxford commas more consistently
  Polish casing
  Fix typo’s
  Refactor wording
  legal team considerations
  fix dupe blank lines warning
  rewrite "which license" section
  @aitchabee feedback #20 (review)
  fix warnings
  fix internal link
  CLA section edits
  ...
@bkeepers
Copy link
Author

Want me to add the plugin to GH-40, or create a new one?

I merged #40, so go ahead and push changes to this branch.

Add linting of prose for quote and apostrophe style (preferring
straight over smart marks).
@wooorm
Copy link
Contributor

wooorm commented Aug 18, 2016

@bkeepers Done

@bkeepers
Copy link
Author

Thanks so much! It's so interesting to see the implementation of these plugins.

@bkeepers bkeepers merged commit 6b02f2e into gh-pages Aug 18, 2016
@bkeepers bkeepers deleted the quotes branch August 18, 2016 20:25
@wooorm
Copy link
Contributor

wooorm commented Aug 18, 2016

👌 It’s really fun to work with retext again, creating the plugins. I’ve been working on the whole ecosystem a lot recently, markdown and HTML mostly. Way back when I started retext in 2014, I didn’t really think about the power of linting too much. So it’s really cool to see how powerful it can be compared to the time/code required.

Let me know if you have some more ideas!

@bkeepers
Copy link
Author

Let me know if you have some more ideas!

ooh, I do. 😁

I'll open an issue with lint feature requests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants