-
Notifications
You must be signed in to change notification settings - Fork 187
Closed
Description
It looks like the update to 3.0.9 introduced an infinite loop in the <relative-time />
element.
Repro Link:
https://codesandbox.io/s/thirsty-joliot-44k9p
Repro Steps:
- Open link
- Open browser console
- Refresh
Uncaught RangeError: Maximum call stack size exceeded.
at HTMLElement.attributeChangedCallback (time-elements-legacy.js:248)
at HTMLElement.attributeChangedCallback (time-elements-legacy.js:248)
at HTMLElement.attributeChangedCallback (time-elements-legacy.js:248)
at HTMLElement.attributeChangedCallback (time-elements-legacy.js:248)
at HTMLElement.attributeChangedCallback (time-elements-legacy.js:248)
at HTMLElement.attributeChangedCallback (time-elements-legacy.js:248)
at HTMLElement.attributeChangedCallback (time-elements-legacy.js:248)
at HTMLElement.attributeChangedCallback (time-elements-legacy.js:248)
at HTMLElement.attributeChangedCallback (time-elements-legacy.js:248)
at HTMLElement.attributeChangedCallback (time-elements-legacy.js:248)
at HTMLElement.attributeChangedCallback (time-elements-legacy.js:248)
at HTMLElement.attributeChangedCallback (time-elements-legacy.js:248)
at HTMLElement.attributeChangedCallback (time-elements-legacy.js:248)
at HTMLElement.attributeChangedCallback (time-elements-legacy.js:248)
at HTMLElement.attributeChangedCallback (time-elements-legacy.js:248)
at HTMLElement.attributeChangedCallback (time-elements-legacy.js:248)
at HTMLElement.attributeChangedCallback (time-elements-legacy.js:248)
at HTMLElement.attributeChangedCallback (time-elements-legacy.js:248)
at HTMLElement.attributeChangedCallback (time-elements-legacy.js:248)
at HTMLElement.attributeChangedCallback (time-elements-legacy.js:248)
at HTMLElement.attributeChangedCallback (time-elements-legacy.js:248)
at HTMLElement.attributeChangedCallback (time-elements-legacy.js:248)
at HTMLElement.attributeChangedCallback (time-elements-legacy.js:248)
at HTMLElement.attributeChangedCallback (time-elements-legacy.js:248)
at HTMLElement.attributeChangedCallback (time-elements-legacy.js:248)
at HTMLElement.attributeChangedCallback (time-elements-legacy.js:248)
at HTMLElement.attributeChangedCallback (time-elements-legacy.js:248)
at HTMLElement.attributeChangedCallback (time-elements-legacy.js:248)
at HTMLElement.attributeChangedCallback (time-elements-legacy.js:248)
at HTMLElement.attributeChangedCallback (time-elements-legacy.js:248)
at HTMLElement.attributeChangedCallback (time-elements-legacy.js:248)
at HTMLElement.attributeChangedCallback (time-elements-legacy.js:248)
at HTMLElement.attributeChangedCallback (time-elements-legacy.js:248)
at HTMLElement.attributeChangedCallback (time-elements-legacy.js:248)
at HTMLElement.attributeChangedCallback (time-elements-legacy.js:248)
at HTMLElement.attributeChangedCallback (time-elements-legacy.js:248)
at HTMLElement.attributeChangedCallback (time-elements-legacy.js:248)
at HTMLElement.attributeChangedCallback (time-elements-legacy.js:248)
at HTMLElement.attributeChangedCallback (time-elements-legacy.js:248)
at HTMLElement.attributeChangedCallback (time-elements-legacy.js:248)
at HTMLElement.attributeChangedCallback (time-elements-legacy.js:248)
at HTMLElement.attributeChangedCallback (time-elements-legacy.js:248)
at HTMLElement.attributeChangedCallback (time-elements-legacy.js:248)
at HTMLElement.attributeChangedCallback (time-elements-legacy.js:248)
at evaluate (index.js? [sm]:6)
at Jn (eval.js:61)
at e.value (transpiled-module.ts:980)
at e.value (manager.ts:361)
at t (transpiled-module.ts:958)
at loadResources (index.html:3)
Compare to https://codesandbox.io/s/wizardly-dew-7pih0 which is using 3.0.8 and does not have the issue.
Here is the relevant code:
if (title && (!currentTitle || currentTitle === oldTitle)) {
this.setAttribute('title', title);
}
which I think was modified in this PR:
#129
Metadata
Metadata
Assignees
Labels
No labels