-
Notifications
You must be signed in to change notification settings - Fork 17
Init <remote-input> #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: Kristján Oddsson <koddsson@github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Could we add a flow definition file so we can import the element in github/github
without issues? https://github.com/github/web-systems/issues/215
@@ -1,4 +1,4 @@ | |||
Copyright (c) 2018 GitHub, Inc. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should update this in the template.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we can remove public API functions like fetchResults
in another branch. We don't want anything exposed on the prototype that isn't intended to be public.
Co-Authored-By: David Graham <dgraham@github.com>
Previously
<filterable-input>
. README.Demo page