Skip to content

Init <remote-input> #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
May 13, 2019
Merged

Init <remote-input> #1

merged 18 commits into from
May 13, 2019

Conversation

muan
Copy link
Contributor

@muan muan commented Apr 30, 2019

Previously <filterable-input>. README.

Demo page

@muan muan changed the title Init <filterable-input> Init <remote-input> May 9, 2019
@muan muan marked this pull request as ready for review May 10, 2019 21:00
@muan muan requested a review from a team May 10, 2019 21:01
Copy link
Contributor

@koddsson koddsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Could we add a flow definition file so we can import the element in github/github without issues? https://github.com/github/web-systems/issues/215

@@ -1,4 +1,4 @@
Copyright (c) 2018 GitHub, Inc.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should update this in the template.

Copy link
Contributor

@dgraham dgraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can remove public API functions like fetchResults in another branch. We don't want anything exposed on the prototype that isn't intended to be public.

Co-Authored-By: David Graham <dgraham@github.com>
@muan muan merged commit 26e4705 into master May 13, 2019
@muan muan deleted the init branch May 13, 2019 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants