Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Abort in-flight requests #17

Merged
merged 10 commits into from
Oct 22, 2019
Merged

Abort in-flight requests #17

merged 10 commits into from
Oct 22, 2019

Conversation

dgraham
Copy link
Contributor

@dgraham dgraham commented Oct 18, 2019

Announce a single set of logical network events—loadstart, load, loadend—while aborting all but the final request as an internal optimization.

Closes #14

dgraham and others added 5 commits October 18, 2019 14:32
Announce a single set of logical network events—loadstart, load,
loadend—while aborting all but the final request as an internal
optimization.

Closes #14

Co-authored-by: Mu-An Chiou <me@muanchiou.com>
Co-authored-by: Mu-An Chiou <me@muanchiou.com>
Co-authored-by: Mu-An Chiou <me@muanchiou.com>
Co-authored-by: Mu-An Chiou <me@muanchiou.com>
Co-authored-by: Mu-An Chiou <me@muanchiou.com>
@dgraham dgraham requested a review from a team October 18, 2019 20:59
Copy link
Contributor

@koddsson koddsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Very easy to understand commit messages which makes this easy to review.

@dgraham dgraham merged commit e4d2697 into master Oct 22, 2019
@dgraham dgraham deleted the abort-controller branch October 22, 2019 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cancel old in-flight requests
2 participants