Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Schema Inaccuracy] Pull Request Simple labels.items.properties.description may be null #1812

Open
yanyongyu opened this issue Nov 4, 2022 · 0 comments

Comments

@yanyongyu
Copy link

Schema Inaccuracy

The Pull Request Simple object field labels.items.properties.description may be null, as the Pull Request object.

schemas:
  # incorrect
  pull-request-simple:
    type: object
    title: Pull Request Simple
    properties:
      labels:
      type: array
      items:
        properties:
          description:
            type: string

  # correct
  pull-request:
    type: object
    title: Pull Request
    properties:
      labels:
      type: array
      items:
        properties:
          description:
            type:
            - string
            - 'null'

Expected

change the repo field to oneof repository / type: null

Reproduction Steps

list pull request using curl -X GET https://api.github.com/repos/apache/pulsar/pulls?state=open

Related to yanyongyu/githubkit#7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants