Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate accessibility rubocop rule NoRedundantImageAlt from dotcom to erblint-github #106

Conversation

bolonio
Copy link
Contributor

@bolonio bolonio commented Jul 28, 2022

Context

The motivation of rubocop-github is to open-source our accessibility rubocop rules so non-GitHub people can benefit from them, have a space to provide comprehensive rule documentation, and also allow rules to be shared between Rails projects.

This PR migrates the accessibility rule NoRedundantImageAlt from dotcom to rubocop-github

Related Issue

Copy link

@khiga8 khiga8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar suggestion as #105 (review) 🙏

@bolonio bolonio requested a review from khiga8 August 1, 2022 09:10
@bolonio bolonio force-pushed the accessibility/issues/1430/migrate-a11y-rubocop-rules-no-redundant-image-alt branch from 6180e11 to fd729fa Compare August 1, 2022 09:13
Copy link

@khiga8 khiga8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job 🎉

Copy link

@khiga8 khiga8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@bolonio bolonio merged commit 90f9504 into master Aug 1, 2022
@bolonio bolonio deleted the accessibility/issues/1430/migrate-a11y-rubocop-rules-no-redundant-image-alt branch August 1, 2022 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants