Use transaction mechanism instead of explicit BEGIN/COMMIT

[hendrikvanantwerpen]

◀️ #262

Per @dcreager's suggestion, this PR replaces explicit BEGIN/COMMIT with the transaction() mechanism of Rusqlite. This should result in more robust behavior when errors occur, because the open transaction is rolled back as soon as the transaction object is dropped.

[github-actions]

Performance Summary

Comparing base 303bb12 with head 1ee1c9b on microsoft/TypeScript@v4.9.5. For details see workflow artifacts. Note that performance is tested on the last commits with changes in stack-graphs, not on every commit.

Before

--------------------------------------------------------------------------------
Command:            base/target/release/tree-sitter-stack-graphs-typescript index -D base.sqlite --max-file-time=30 --hide-error-details -- test/src/compiler
Massif arguments:   --massif-out-file=perf.out
ms_print arguments: --x=72 --y=12 base-perf-results/perf.out
--------------------------------------------------------------------------------


    GB
2.300^                                   #                                    
     |                                   #                                    
     |                                   #                                    
     |                                   #                                    
     |                                   #                                    
     |                                   #                                    
     |     :                            :#                                    
     |     :    ::                      :#                                    
     |     :    :                   :   :#                                    
     |     :    :        :         ::   :#                            : :     
     |     :    :   :    :  :      ::   :#   :                        : :     
     |    ::    :   :   ::  :   :: :: :::#  ::    : ::   ::    :  :  :::@ ::  
   0 +----------------------------------------------------------------------->Gi
     0                                                                   238.5

After

--------------------------------------------------------------------------------
Command:            head/target/release/tree-sitter-stack-graphs-typescript index -D head.sqlite --max-file-time=30 --hide-error-details -- test/src/compiler
Massif arguments:   --massif-out-file=perf.out
ms_print arguments: --x=72 --y=12 head-perf-results/perf.out
--------------------------------------------------------------------------------


    GB
2.300^                                   #                                    
     |                                   #                                    
     |                                   #                                    
     |                                   #                                    
     |                                   #                                    
     |                                   #                                    
     |                                  :#           :     @                  
     |          :                       :#           :     @                  
     |          :                   ::  :#           :     @                  
     |     :    :                   ::  :#        :  :    :@            :     
     |     ::   :      :::: ::      ::  :#        : @::   :@         :@ ::    
     |     ::   : : :: :::: ::  @:  :: ::# ::@  : ::@::  ::@      ::::@:::::  
   0 +----------------------------------------------------------------------->Gi
     0                                                                   234.8

[github-actions]

Performance Summary

Comparing base b1a2d37 with head e234bf8 on microsoft/TypeScript@v4.9.5. For details see workflow artifacts. Note that performance is tested on the last commits with changes in stack-graphs, not on every commit.

Before

--------------------------------------------------------------------------------
Command:            base/target/release/tree-sitter-stack-graphs-typescript index -D base.sqlite --max-file-time=30 --hide-error-details -- test/src/compiler
Massif arguments:   --massif-out-file=perf.out
ms_print arguments: --x=72 --y=12 base-perf-results/perf.out
--------------------------------------------------------------------------------


    GB
1.234^                                               #                        
     |                                  :            #                        
     |                                  :            #                        
     |           ::                     :            #                        
     |           :                      :            #                        
     |           :                  :   :            #                        
     |     ::    :   :              :   :            #                  :     
     |     :     :   :      :       :   :            #                  :     
     |     :    ::   :      :       :   :            #               ::::     
     |     :    :: : :      :       :   :  :  :     :#   :      :    :::: :   
     |    ::    :: :::   : @:  ::   : :::  :  :     :#   :::    ::   :::: :   
     |    :: @@ :: :::  :: @: :: : :: :::  :  :  ::::# : ::  @@::: : ::::::   
   0 +----------------------------------------------------------------------->Gi
     0                                                                   216.9

After

--------------------------------------------------------------------------------
Command:            head/target/release/tree-sitter-stack-graphs-typescript index -D head.sqlite --max-file-time=30 --hide-error-details -- test/src/compiler
Massif arguments:   --massif-out-file=perf.out
ms_print arguments: --x=72 --y=12 head-perf-results/perf.out
--------------------------------------------------------------------------------


    GB
2.300^                                   #                                    
     |                                   #                                    
     |                                   #                                    
     |                                   #                                    
     |                                   #                                    
     |           @       @               #                                    
     |     @     @       @              :#           :    @                   
     |     @     @       @              :#           :    @                   
     |     @    :@       @          :   :#           :    @                   
     |     @    :@       @         ::   :#           :    @            ::     
     |     @    :@     : @  :      :: :::#           :    @         :: :::    
     |    :@   @:@     ::@  :      :: @ :# :    :: :@: : :@  :  @  ::::@:: :  
   0 +----------------------------------------------------------------------->Gi
     0                                                                   237.4

[github-actions]

Performance Summary

Comparing base 230c1ae with head afb98e0 on microsoft/TypeScript@v4.9.5. For details see workflow artifacts. Note that performance is tested on the last commits with changes in stack-graphs, not on every commit.

Before

--------------------------------------------------------------------------------
Command:            base/target/release/tree-sitter-stack-graphs-typescript index -D base.sqlite --max-file-time=30 --hide-error-details -- test/src/compiler
Massif arguments:   --massif-out-file=perf.out
ms_print arguments: --x=72 --y=12 base-perf-results/perf.out
--------------------------------------------------------------------------------


    GB
1.234^                                              #                         
     |      @@                                      #                         
     |      @                                       #                         
     |      @                                       #                         
     |      @                                       #                         
     |      @                                       #                         
     |      @                                       #                  :      
     |      @               ::                  ::  #                 ::      
     |      @            :  :                   :   #                 ::      
     |      @    ::::    :  :       :     :   : :   #                 ::      
     |    @@@    : : ::  : ::      ::  :  :   : :  :#    :            :: :    
     |    @ @ ::@: : ::  : :: : :  ::::: ::   : : ::# :: ::   :::: :  :: : :  
   0 +----------------------------------------------------------------------->Gi
     0                                                                   212.0

After

--------------------------------------------------------------------------------
Command:            head/target/release/tree-sitter-stack-graphs-typescript index -D head.sqlite --max-file-time=30 --hide-error-details -- test/src/compiler
Massif arguments:   --massif-out-file=perf.out
ms_print arguments: --x=72 --y=12 head-perf-results/perf.out
--------------------------------------------------------------------------------


    GB
1.234^                                               #                        
     |      @                                        #                        
     |      @                                        #                        
     |      @                                        #                        
     |      @                       ::               #                        
     |      @    :                  :                #                        
     |     :@    :    :             :                #   @@            ::     
     |     :@    :    :      :      :            :   #   @           ::::     
     |     :@    :    :  :  ::      :  :         :   #   @           ::::     
     |     :@    :    :  :  ::      :  :      @  :   #   @           ::::     
     |     @@    :::  :  :  ::  :   :  :: :   @  : ::#   @         : ::::     
     |     @@    :::::::::  :: :::  :  :::::  @  : : #: :@  :: :  @:::::::@: :
   0 +----------------------------------------------------------------------->Gi
     0                                                                   208.7

[rewinfrey]

Thanks for this update, 👍