Skip to content

Ensure remote queries can handle codeql-pack.yml files #1933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 11, 2023

Conversation

aeisenberg
Copy link
Contributor

This updates one of our integration tests so that it uses codeql-pack.yml instead of qlpack.yml.

@aeisenberg aeisenberg requested review from a team as code owners January 6, 2023 00:27
Copy link
Contributor

@charisk charisk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change LGTM - would be cool if we could cover with a test too.

@aeisenberg
Copy link
Contributor Author

Change LGTM - would be cool if we could cover with a test too.

I did add a test for this. One of the query packs in the test folder now uses codeql-pack.yml and the other uses qlpack.yml.

@aeisenberg aeisenberg force-pushed the aeisenberg/codeql-pack-yml branch 2 times, most recently from d3f93c0 to d6019eb Compare January 6, 2023 16:49
Copy link
Contributor

@charisk charisk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it!

@aeisenberg aeisenberg force-pushed the aeisenberg/codeql-pack-yml branch from d6019eb to 29e7923 Compare January 11, 2023 21:47
This updates one of our integration tests so that it uses
`codeql-pack.yml` instead of `qlpack.yml`.
@aeisenberg aeisenberg force-pushed the aeisenberg/codeql-pack-yml branch from 29e7923 to 77c6706 Compare January 11, 2023 22:36
@aeisenberg aeisenberg merged commit 6f16845 into main Jan 11, 2023
@aeisenberg aeisenberg deleted the aeisenberg/codeql-pack-yml branch January 11, 2023 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants