Don't attempt to interpret results when running quick-eval #4141
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
459d6a9 introduced a bug where quickEvalPosition -- which indicates that the query was spawned via quick-eval -- was not being passed through in the completed query info. This meant the extension tried to interpret the results with the metadata from the enclosing file, which would then fail if it was a .ql file with metadata.
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug where quick evaluation within .ql files caused spurious errors about processing query metadata. The issue was that quickEvalPosition was not being passed through in the completed query info, causing the extension to incorrectly attempt to interpret quick-eval results with metadata from the enclosing file.
- Pass
quickEvalPositionfrom query info to completed query info instead ofundefined - Add changelog entry documenting the bug fix
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| extensions/ql-vscode/src/local-queries/local-query-run.ts | Pass through quickEvalPosition to prevent incorrect metadata interpretation |
| extensions/ql-vscode/CHANGELOG.md | Add changelog entry for the bug fix |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
alexet
approved these changes
Sep 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#4037 introduced a bug where
quickEvalPosition— which indicates that the query was spawned via quick-eval — was not being passed through in the completed query info. This meant the extension tried to interpret the results with the metadata from the enclosing file, which would then fail if it was a.qlfile with a@kindthat required a particular named query-predicate.