fix: only show showNotificationsCountInTray setting on MacOS

[adufr]

Looks like the Electron method we're using for the showNotificationsCountInTray setting is MacOS only 🙈

[setchy]

@adufr - we should also update the following, right?

gitify/src/context/App.tsx

Lines 117 to 122 in 23c1bae

	if (settings.showNotificationsCountInTray && count > 0) {
	updateTrayTitle(count.toString());
	} else {
	updateTrayTitle();
	}
	}, [settings.showNotificationsCountInTray, notifications]);

[adufr]

Mmh I don't know, the setting is false by default, so this shouldn't be a problem..?

[setchy]

Mmh I don't know, the setting is false by default, so this shouldn't be a problem..?

what if someone has changed it already ;) now that you're hiding the setting, they won't be able to disable it

[setchy]

I'm also torn between hiding the setting, or disabling it and having a tooltip explaining what this is macOS only...

[adufr]

what if someone has changed it already ;) now that you're hiding the setting, they won't be able to disable it

k but how do we handle this case? should we return early in this useEffect if the platform isn't MacOS?
and I don't know how electron behaves if you call a feature that isn't available on your platform but I think that it must fail silently so even if some people enabled it I don't think this causes any issues

I'm also torn between hiding the setting, or disabling it and having a tooltip explaining what this is macOS only...

I don't really see the point of having a setting that you will never be able to turn on 😅

[bmulholland]

Yeah, IMHO best practice here would be to hide the setting AND force it to false wherever it's used (overriding anyone who sets it to true so far, because of a future bug, etc)