Skip to content

refactor: extract discussions api calls into client #1085

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 6, 2024
Merged

refactor: extract discussions api calls into client #1085

merged 4 commits into from
May 6, 2024

Conversation

setchy
Copy link
Member

@setchy setchy commented May 5, 2024

Extract the discussions GraphQL API call into our api/client, along with the GQL operation document and supporting helpers

@setchy setchy added the refactor Refactoring of existing feature label May 5, 2024
@setchy setchy added this to the Release 5.5.0 milestone May 5, 2024
afonsojramos
afonsojramos approved these changes May 6, 2024
View reviewed changes
Copy link
Member

@afonsojramos afonsojramos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup! There's always more! ahaha 🧽

@setchy setchy merged commit b1cb56b into main May 6, 2024
@setchy setchy deleted the refactor/discussions-client branch May 6, 2024 05:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afonsojramos afonsojramos afonsojramos approved these changes

@bmulholland bmulholland Awaiting requested review from bmulholland bmulholland is a code owner

Assignees
No one assigned
Labels
refactor Refactoring of existing feature
Projects
None yet
Milestone
Release 5.5.0
Development

Successfully merging this pull request may close these issues.
2 participants
@setchy @afonsojramos