Skip to content

refactor: main script #1098

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
May 14, 2024
Merged

refactor: main script #1098

merged 5 commits into from
May 14, 2024

Conversation

setchy
Copy link
Member

@setchy setchy commented May 8, 2024

Update main.js to

@setchy setchy added the refactor Refactoring of existing feature label May 8, 2024
@setchy setchy added this to the Release 5.6.0 milestone May 8, 2024
@setchy setchy changed the title refactor: organize main refactor: main script May 8, 2024
@setchy setchy marked this pull request as draft May 9, 2024 10:49
@setchy
Copy link
Member Author

setchy commented May 9, 2024

Will leave in draft until #1097 is merged

@setchy
Copy link
Member Author

setchy commented May 13, 2024

Actually, since #1097 is still addressing testing feedback, let's move this one through first...

@setchy setchy marked this pull request as ready for review May 13, 2024 19:43
@afonsojramos afonsojramos merged commit 2e95afa into main May 14, 2024
@afonsojramos afonsojramos deleted the refactor/main-menubarapp branch May 14, 2024 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afonsojramos afonsojramos afonsojramos approved these changes

@bmulholland bmulholland Awaiting requested review from bmulholland bmulholland is a code owner

Assignees
No one assigned
Labels
refactor Refactoring of existing feature
Projects
None yet
Milestone
Release 5.6.0
Development

Successfully merging this pull request may close these issues.
2 participants
@setchy @afonsojramos