-
Notifications
You must be signed in to change notification settings - Fork 275
feat: support multiple accounts #1201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I think this is ready for review and ideally further local testing. |
looking into the test coverage drop 👀 |
when you scroll, do you see the duplicate account header and notifications? were you expecting it to be interactive (spoiler: i was too, but atm, it isn't) |
ha - you found the edge case straight away... yep, haven't implemented any duplicate checking - figured that can just be handled by end-users :) |
This PR adds support for multiple GitHub Cloud or GitHub Enterprise Service accounts. 🎉
Majority of the code changes were to:
getAccountUUID
for notification interactions (mark as read, raise native notifications, etc) so that state is correctly managed per account and not per hostnameCloses #365