Skip to content

Conversation

setchy
Copy link
Member

@setchy setchy commented Aug 11, 2024

Upon logging out, notification counts metrics were still being shown in the Sidebar.

This PR ensures the upon logout the account is removed from account notifications state

Signed-off-by: Adam Setch <adam.setch@outlook.com>
@setchy setchy added this to the Release 5.13.0 milestone Aug 11, 2024
@github-actions github-actions bot added the bug Something isn't working label Aug 11, 2024
@setchy setchy marked this pull request as draft August 12, 2024 19:36
@setchy setchy changed the title fix: only show notification count when logged in fix: remove account notifications on logout Aug 12, 2024
Signed-off-by: Adam Setch <adam.setch@outlook.com>
@setchy setchy marked this pull request as ready for review August 12, 2024 19:47
@afonsojramos afonsojramos merged commit e7b843b into main Aug 12, 2024
11 checks passed
@afonsojramos afonsojramos deleted the fix/login-notif-count branch August 12, 2024 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants