refactor: rename showAccountHostname to showAccountHeader
#1464
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Adam Setch <adam.setch@outlook.com>
setchy
changed the title
showAccountHostname to showAccountHeader
|
Isn't there a way to migrate existing setting state? We could add code to port over the setting, if set, and keep it in for a few releases. |
we have account migration logic, but not setting atm. i think we should be ok this time :) |
bmulholland
approved these changes
Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From our simple beginnings as a
hostnameonly account header, we have grown to now show avatar, login name, account-specific quick links and more.As such, it's time to rename these vars.
The setting rename is somewhat breaking, but given it's a setting that isn't that commonly used (assumption), i think it's OK