Skip to content

feat: truncate long avatar names #1792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 30, 2025
Merged

feat: truncate long avatar names #1792

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
808b331
feat: avatar length handling
setchy Jan 30, 2025
5ea227b
feat: avatar length handling
setchy Jan 30, 2025
f53ec79
feat: avatar length handling
setchy Jan 30, 2025
9a4b94f
feat: avatar length handling
setchy Jan 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions src/renderer/components/avatars/AvatarWithFallback.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import type React from 'react';
import { useState } from 'react';

import { FeedPersonIcon, MarkGithubIcon } from '@primer/octicons-react';
import { Avatar, Stack, Text } from '@primer/react';
import { Avatar, Stack, Truncate } from '@primer/react';

import { type Link, Size } from '../../types';
import type { UserType } from '../../typesGitHub';
Expand Down Expand Up @@ -34,7 +34,6 @@ export const AvatarWithFallback: React.FC<IAvatarWithFallback> = ({
align="center"
gap="condensed"
data-testid="avatar"
className="truncate"
>
{!src || isBroken ? (
isNonHuman ? (
Expand All @@ -52,10 +51,9 @@ export const AvatarWithFallback: React.FC<IAvatarWithFallback> = ({
/>
)}
{name && (
// TODO add truncation logic for long names
<Text className="block truncate flex-shrink overflow-ellipsis">
<Truncate title={name} inline maxWidth={280}>
{name}
</Text>
</Truncate>
)}
</Stack>
);
Expand Down
100 changes: 60 additions & 40 deletions src/renderer/components/avatars/__snapshots__/AvatarWithFallback.test.tsx.snap
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading