feat(filters): reduce api calls for filtered detailed notifications #2158
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Adam Setch <adam.setch@outlook.com>
Signed-off-by: Adam Setch <adam.setch@outlook.com>
github-actions
bot
added
the
enhancement
Signed-off-by: Adam Setch <adam.setch@outlook.com>
Signed-off-by: Adam Setch <adam.setch@outlook.com>
Signed-off-by: Adam Setch <adam.setch@outlook.com>
|
@grahamj - part two. thanks for the suggestion 🙇 |
…fy-app/gitify into feat/performance-post-state
Signed-off-by: Adam Setch <adam.setch@outlook.com>
setchy
changed the title
Signed-off-by: Adam Setch <adam.setch@outlook.com>
…-state Signed-off-by: Adam Setch <adam.setch@outlook.com>
|
|
Amazing, thanks very much! |
|
Nice work on these! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part two of optimizing API calls #1997
Will check after fetching the notification state if there is a need to continue with additional enrichment, or if it can exit early. Similarly for user filters before fetching reviewer details