Skip to content

fix: use IssueOpenedIcon for linked issues #2194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 29, 2025
Merged

fix: use IssueOpenedIcon for linked issues #2194

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/renderer/components/metrics/MetricGroup.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import { type FC, useContext } from 'react';

import {
CommentIcon,
IssueClosedIcon,
IssueOpenedIcon,
MilestoneIcon,
TagIcon,
} from '@primer/octicons-react';
Expand Down Expand Up @@ -40,8 +40,8 @@ export const MetricGroup: FC<IMetricGroup> = ({
<Box className="flex gap-1">
{notification.subject?.linkedIssues?.length > 0 && (
<MetricPill
color={IconColor.GREEN}
icon={IssueClosedIcon}
color={IconColor.GRAY}
icon={IssueOpenedIcon}
metric={notification.subject.linkedIssues.length}
title={linkedIssuesPillDescription}
/>
Expand Down
96 changes: 48 additions & 48 deletions src/renderer/components/metrics/__snapshots__/MetricGroup.test.tsx.snap
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions src/renderer/components/settings/NotificationSettings.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import {
CheckIcon,
CommentIcon,
GitPullRequestIcon,
IssueClosedIcon,
IssueOpenedIcon,
MilestoneIcon,
TagIcon,
} from '@primer/octicons-react';
Expand Down Expand Up @@ -105,7 +105,7 @@ export const NotificationSettings: FC = () => {
<Box className="pl-4">
<Stack direction="vertical" gap="none">
<Stack direction="horizontal" gap="condensed">
<IssueClosedIcon size={Size.SMALL} />
<IssueOpenedIcon size={Size.SMALL} />
linked issues
</Stack>
<Stack direction="horizontal" gap="condensed">
Expand Down Expand Up @@ -150,7 +150,7 @@ export const NotificationSettings: FC = () => {
</li>
<li>
<Stack direction="horizontal" gap="condensed">
<IssueClosedIcon size={Size.SMALL} />
<IssueOpenedIcon size={Size.SMALL} />
Issue
</Stack>
</li>
Expand Down
Loading