Skip to content

test: remove unused memoryrouter #2212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 6, 2025
Merged

test: remove unused memoryrouter #2212

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions src/renderer/components/AllRead.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import { act, render } from '@testing-library/react';
import { MemoryRouter } from 'react-router-dom';

import { mockSettings } from '../__mocks__/state-mocks';
import { ensureStableEmojis } from '../__mocks__/utils';
Expand Down Expand Up @@ -44,9 +43,7 @@ describe('renderer/components/AllRead.tsx', () => {
},
}}
>
<MemoryRouter>
<AllRead />
</MemoryRouter>
<AllRead />
</AppContext.Provider>,
);
});
Expand Down
55 changes: 24 additions & 31 deletions src/renderer/components/filters/FilterSection.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import { act, render, screen } from '@testing-library/react';
import userEvent from '@testing-library/user-event';
import { MemoryRouter } from 'react-router-dom';

import { MarkGithubIcon } from '@primer/octicons-react';

Expand Down Expand Up @@ -29,18 +28,16 @@ describe('renderer/components/filters/FilterSection.tsx', () => {
notifications: mockAccountNotifications,
}}
>
<MemoryRouter>
<FilterSection
filter={{
...mockFilter,
requiresDetailsNotifications: true,
}}
filterSetting={mockFilterSetting}
icon={MarkGithubIcon}
id={'FilterSectionTest'}
title={'FilterSectionTitle'}
/>
</MemoryRouter>
<FilterSection
filter={{
...mockFilter,
requiresDetailsNotifications: true,
}}
filterSetting={mockFilterSetting}
icon={MarkGithubIcon}
id={'FilterSectionTest'}
title={'FilterSectionTitle'}
/>
</AppContext.Provider>,
);

Expand Down Expand Up @@ -88,15 +85,13 @@ describe('renderer/components/filters/FilterSection.tsx', () => {
updateFilter,
}}
>
<MemoryRouter>
<FilterSection
filter={mockFilter}
filterSetting={mockFilterSetting}
icon={MarkGithubIcon}
id={'FilterSectionTest'}
title={'FilterSectionTitle'}
/>
</MemoryRouter>
<FilterSection
filter={mockFilter}
filterSetting={mockFilterSetting}
icon={MarkGithubIcon}
id={'FilterSectionTest'}
title={'FilterSectionTitle'}
/>
</AppContext.Provider>,
);
});
Expand All @@ -123,15 +118,13 @@ describe('renderer/components/filters/FilterSection.tsx', () => {
updateFilter,
}}
>
<MemoryRouter>
<FilterSection
filter={mockFilter}
filterSetting={mockFilterSetting}
icon={MarkGithubIcon}
id={'FilterSectionTest'}
title={'FilterSectionTitle'}
/>
</MemoryRouter>
<FilterSection
filter={mockFilter}
filterSetting={mockFilterSetting}
icon={MarkGithubIcon}
id={'FilterSectionTest'}
title={'FilterSectionTitle'}
/>
</AppContext.Provider>,
);
});
Expand Down
5 changes: 1 addition & 4 deletions src/renderer/components/filters/ReasonFilter.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import { render } from '@testing-library/react';
import { MemoryRouter } from 'react-router-dom';

import { mockAccountNotifications } from '../../__mocks__/notifications-mocks';
import { mockSettings } from '../../__mocks__/state-mocks';
Expand All @@ -15,9 +14,7 @@ describe('renderer/components/filters/ReasonFilter.tsx', () => {
notifications: mockAccountNotifications,
}}
>
<MemoryRouter>
<ReasonFilter />
</MemoryRouter>
<ReasonFilter />
</AppContext.Provider>,
);

Expand Down
5 changes: 1 addition & 4 deletions src/renderer/components/filters/RequiresDetailedNotificationsWarning.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import { render } from '@testing-library/react';
import { MemoryRouter } from 'react-router-dom';

import { mockAccountNotifications } from '../../__mocks__/notifications-mocks';
import { mockSettings } from '../../__mocks__/state-mocks';
Expand All @@ -15,9 +14,7 @@ describe('renderer/components/filters/RequiresDetailedNotificationsWarning.tsx',
notifications: mockAccountNotifications,
}}
>
<MemoryRouter>
<RequiresDetailedNotificationWarning />
</MemoryRouter>
<RequiresDetailedNotificationWarning />
</AppContext.Provider>,
);

Expand Down
5 changes: 1 addition & 4 deletions src/renderer/components/filters/StateFilter.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import { render } from '@testing-library/react';
import { MemoryRouter } from 'react-router-dom';

import { mockAccountNotifications } from '../../__mocks__/notifications-mocks';
import { mockSettings } from '../../__mocks__/state-mocks';
Expand All @@ -19,9 +18,7 @@ describe('renderer/components/filters/StateFilter.tsx', () => {
notifications: mockAccountNotifications,
}}
>
<MemoryRouter>
<StateFilter />
</MemoryRouter>
<StateFilter />
</AppContext.Provider>,
);

Expand Down
5 changes: 1 addition & 4 deletions src/renderer/components/filters/SubjectTypeFilter.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import { render } from '@testing-library/react';
import { MemoryRouter } from 'react-router-dom';

import { mockAccountNotifications } from '../../__mocks__/notifications-mocks';
import { mockSettings } from '../../__mocks__/state-mocks';
Expand All @@ -18,9 +17,7 @@ describe('renderer/components/filters/SubjectTypeFilter.tsx', () => {
notifications: mockAccountNotifications,
}}
>
<MemoryRouter>
<SubjectTypeFilter />
</MemoryRouter>
<SubjectTypeFilter />
</AppContext.Provider>,
);

Expand Down
25 changes: 6 additions & 19 deletions src/renderer/components/filters/UserHandleFilter.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import { act, render, screen } from '@testing-library/react';
import userEvent from '@testing-library/user-event';
import { MemoryRouter } from 'react-router-dom';

import { mockAccountNotifications } from '../../__mocks__/notifications-mocks';
import { mockSettings } from '../../__mocks__/state-mocks';
Expand All @@ -27,9 +26,7 @@ describe('renderer/components/filters/UserHandleFilter.tsx', () => {
notifications: mockAccountNotifications,
}}
>
<MemoryRouter>
<UserHandleFilter />
</MemoryRouter>
<UserHandleFilter />
</AppContext.Provider>,
);

Expand All @@ -47,9 +44,7 @@ describe('renderer/components/filters/UserHandleFilter.tsx', () => {
notifications: mockAccountNotifications,
}}
>
<MemoryRouter>
<UserHandleFilter />
</MemoryRouter>
<UserHandleFilter />
</AppContext.Provider>,
);

Expand All @@ -71,9 +66,7 @@ describe('renderer/components/filters/UserHandleFilter.tsx', () => {
updateFilter,
}}
>
<MemoryRouter>
<UserHandleFilter />
</MemoryRouter>
<UserHandleFilter />
</AppContext.Provider>,
);
});
Expand Down Expand Up @@ -103,9 +96,7 @@ describe('renderer/components/filters/UserHandleFilter.tsx', () => {
updateFilter,
}}
>
<MemoryRouter>
<UserHandleFilter />
</MemoryRouter>
<UserHandleFilter />
</AppContext.Provider>,
);
});
Expand Down Expand Up @@ -133,9 +124,7 @@ describe('renderer/components/filters/UserHandleFilter.tsx', () => {
updateFilter,
}}
>
<MemoryRouter>
<UserHandleFilter />
</MemoryRouter>
<UserHandleFilter />
</AppContext.Provider>,
);
});
Expand Down Expand Up @@ -165,9 +154,7 @@ describe('renderer/components/filters/UserHandleFilter.tsx', () => {
updateFilter,
}}
>
<MemoryRouter>
<UserHandleFilter />
</MemoryRouter>
<UserHandleFilter />
</AppContext.Provider>,
);
});
Expand Down
5 changes: 1 addition & 4 deletions src/renderer/components/filters/UserTypeFilter.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import { render } from '@testing-library/react';
import { MemoryRouter } from 'react-router-dom';

import { mockAccountNotifications } from '../../__mocks__/notifications-mocks';
import { mockSettings } from '../../__mocks__/state-mocks';
Expand All @@ -19,9 +18,7 @@ describe('renderer/components/filters/UserTypeFilter.tsx', () => {
notifications: mockAccountNotifications,
}}
>
<MemoryRouter>
<UserTypeFilter />
</MemoryRouter>
<UserTypeFilter />
</AppContext.Provider>,
);

Expand Down
25 changes: 6 additions & 19 deletions src/renderer/components/settings/AppearanceSettings.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import { act, fireEvent, render, screen } from '@testing-library/react';
import userEvent from '@testing-library/user-event';
import { MemoryRouter } from 'react-router-dom';

import {
mockAuth,
Expand Down Expand Up @@ -28,9 +27,7 @@ describe('renderer/components/settings/AppearanceSettings.tsx', () => {
updateSetting,
}}
>
<MemoryRouter>
<AppearanceSettings />
</MemoryRouter>
<AppearanceSettings />
</AppContext.Provider>,
);
});
Expand All @@ -56,9 +53,7 @@ describe('renderer/components/settings/AppearanceSettings.tsx', () => {
updateSetting,
}}
>
<MemoryRouter>
<AppearanceSettings />
</MemoryRouter>
<AppearanceSettings />
</AppContext.Provider>,
);
});
Expand All @@ -81,9 +76,7 @@ describe('renderer/components/settings/AppearanceSettings.tsx', () => {
updateSetting,
}}
>
<MemoryRouter>
<AppearanceSettings />
</MemoryRouter>
<AppearanceSettings />
</AppContext.Provider>,
);
});
Expand Down Expand Up @@ -111,9 +104,7 @@ describe('renderer/components/settings/AppearanceSettings.tsx', () => {
updateSetting,
}}
>
<MemoryRouter>
<AppearanceSettings />
</MemoryRouter>
<AppearanceSettings />
</AppContext.Provider>,
);
});
Expand Down Expand Up @@ -166,9 +157,7 @@ describe('renderer/components/settings/AppearanceSettings.tsx', () => {
updateSetting,
}}
>
<MemoryRouter>
<AppearanceSettings />
</MemoryRouter>
<AppearanceSettings />
</AppContext.Provider>,
);
});
Expand All @@ -191,9 +180,7 @@ describe('renderer/components/settings/AppearanceSettings.tsx', () => {
updateSetting,
}}
>
<MemoryRouter>
<AppearanceSettings />
</MemoryRouter>
<AppearanceSettings />
</AppContext.Provider>,
);
});
Expand Down
Loading
Loading