Skip to content

refactor: sonar issue reduce -> flatMap #2281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 8, 2025
+20 −22
Merged

refactor: sonar issue reduce -> flatMap #2281

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 20 additions & 22 deletions src/renderer/utils/notifications/native.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,31 +10,29 @@ export const triggerNativeNotifications = (
newNotifications: AccountNotifications[],
state: GitifyState,
) => {
const diffNotifications = newNotifications
.map((accountNotifications) => {
const accountPreviousNotifications = previousNotifications.find(
(item) =>
getAccountUUID(item.account) ===
getAccountUUID(accountNotifications.account),
);
const diffNotifications = newNotifications.flatMap((accountNotifications) => {
const accountPreviousNotifications = previousNotifications.find(
(item) =>
getAccountUUID(item.account) ===
getAccountUUID(accountNotifications.account),
);

if (!accountPreviousNotifications) {
return accountNotifications.notifications;
}
if (!accountPreviousNotifications) {
return accountNotifications.notifications;
}

const accountPreviousNotificationsIds = new Set<string>(
accountPreviousNotifications.notifications.map((item) => item.id),
);
const accountPreviousNotificationsIds = new Set<string>(
accountPreviousNotifications.notifications.map((item) => item.id),
);

const accountNewNotifications = accountNotifications.notifications.filter(
(item) => {
return !accountPreviousNotificationsIds.has(`${item.id}`);
},
);
const accountNewNotifications = accountNotifications.notifications.filter(
(item) => {
return !accountPreviousNotificationsIds.has(`${item.id}`);
},
);

return accountNewNotifications;
})
.reduce((acc, val) => acc.concat(val), []);
return accountNewNotifications;
});

setTrayIconColor(newNotifications);

Expand Down Expand Up @@ -63,7 +61,7 @@ export const raiseNativeNotification = (notifications: Notification[]) => {
? ''
: notification.repository.full_name;
body = notification.subject.title;
// TODO FIXME = set url to notification url
// url intentionally left null (no direct subject URL available)
} else {
title = APPLICATION.NAME;
body = `You have ${notifications.length} notifications`;
Expand Down