Skip to content

refactor: second instance handling #2285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+29 −26
Open

refactor: second instance handling #2285

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3772e70
refactor: second instance handling
setchy Oct 9, 2025
f10f9cf
refactor: second instance handling
setchy Oct 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
55 changes: 29 additions & 26 deletions src/main/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ import {
type IOpenExternal,
} from '../shared/events';
import { logInfo, logWarn } from '../shared/logger';
import { isLinux, isWindows } from '../shared/platform';

import { handleMainEvent, onMainEvent, sendRendererEvent } from './events';
import { onFirstRunMaybe } from './first-run';
Expand Down Expand Up @@ -78,6 +77,8 @@ let shouldUseAlternateIdleIcon = false;
let shouldUseUnreadActiveIcon = true;

app.whenReady().then(async () => {
preventSecondInstance();

await onFirstRunMaybe();

appUpdater.start();
Expand Down Expand Up @@ -116,31 +117,6 @@ app.whenReady().then(async () => {
});
});

/** Prevent second instances */
if (isWindows() || isLinux()) {
const gotTheLock = app.requestSingleInstanceLock();

if (!gotTheLock) {
logWarn('main:gotTheLock', 'Second instance detected, quitting');
app.quit(); // Quit the second instance
return;
}

app.on('second-instance', (_event, commandLine, _workingDirectory) => {
logInfo(
'main:second-instance',
'Second instance was launched. extracting command to forward',
);

// Get the URL from the command line arguments
const url = commandLine.find((arg) => arg.startsWith(`${protocol}://`));

if (url) {
handleURL(url);
}
});
}

/**
* Gitify custom IPC events - no response expected
*/
Expand Down Expand Up @@ -280,3 +256,30 @@ function setActiveIcon() {
function setErrorIcon() {
mb.tray.setImage(TrayIcons.error);
}

/**
* Prevent second instances
*/
function preventSecondInstance() {
const gotTheLock = app.requestSingleInstanceLock();

if (!gotTheLock) {
logWarn('main:gotTheLock', 'Second instance detected, quitting');
app.quit(); // Quit the second instance
return;
}

app.on('second-instance', (_event, commandLine, _workingDirectory) => {
logInfo(
'main:second-instance',
'Second instance was launched. extracting command to forward',
);

// Get the URL from the command line arguments
const url = commandLine.find((arg) => arg.startsWith(`${protocol}://`));

if (url) {
handleURL(url);
}
});
}