fix: only try to open links if non-null url #405
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codebytere
force-pushed
the
missing-url-error
branch
from
74faa12 to
9c3bc30
Compare
codebytere
force-pushed
the
missing-url-error
branch
from
9c3bc30 to
eee185c
Compare
manosim
approved these changes
May 3, 2020
There was a problem hiding this comment.
Looks great, thank you for sorting this out @codebytere 🎉 Any chance you know whether the GraphQL API will support notifications in the future?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a console error borne of attempting to create a GitHub url when the
urlproperty of thesubjectreturned with an individual thread in the Notifications thread in the url is not properly populated.Also fixes a few missing types, but i can get rid of that if you'd prefer!
I've raised an issue with the Notifications team within GitHub about the missing urls, so some of them may end up fixed soon 🤞
cc @manosim