chore: upgrade to Electron v9 #419
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codebytere
force-pushed
the
update-to-electron-9
branch
from
dacccfc to
5869e97
Compare
codebytere
force-pushed
the
update-to-electron-9
branch
from
5869e97 to
c8fcdb5
Compare
|
@codebytere Shall we also update the yarn lockfile? I think it's good to go apart from that 😄 |
codebytere
force-pushed
the
update-to-electron-9
branch
from
c8fcdb5 to
2e9d2c1
Compare
|
Done! |
|
Amazing, thank you so much! Will cut a release branch to create a signed .dmg, test it for a while and then ship it 🚢 |
setchy
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR upgrades gitify to latest stable Electron v9.
This required few changes with the exception of changing the close button to a link. The reason behind this is that Chromium refreshed all their form controls recently (see this blog post) which messed up the coloration of the button on the background:
I figured that changing the button was easier than messing around with all the other background colors etc so that's what i went with. Happy to do something else if you'd prefer tho!
cc @manosim