fix: open GitHub notifications page when clicking on GitHub icon

[hughlilly]

Changes the function that is called when the GitHub icon is clicked. Since the Gitify “G” icon already goes to the Gitify repo, this button was, in effect, a duplicate. It makes sense to provide a way to easily open the GitHub notifications page when there are no new notifications.

Closes #543.

[JakeSidSmith]

LGTM

[afonsojramos]

This doesn't fully make sense. I agree that the link should no longer go to gitify's repo, but is going to notifications logical? If you have notifications you already have the bell icon... It is still an improvement however!

[afonsojramos]

If you're up for it, there are some tests to fix. Otherwise, I'll fix them myself ;)

[hughlilly]

This doesn't fully make sense. I agree that the link should no longer go to gitify's repo, but is going to notifications logical? If you have notifications you already have the bell icon... It is still an improvement however!

Oh I didn’t realise the bell icon went to notifications! I’d argue if there are no notifications it’s still useful to have the bell icon there, but grey, perhaps?

[afonsojramos]

Sounds good! Then I believe we can completely remove the GitHub icon. I see no need for it and see no other usage that would remove the duplication.

[afonsojramos]

Closing this PR in favour of #587.