Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: settings button toggle between settings and notifications #553

Merged
merged 8 commits into from
Sep 14, 2023

Conversation

hughlilly
Copy link
Collaborator

@hughlilly hughlilly commented Sep 23, 2022

Closes #552. Not sure if this is the best way to go about what I’m trying to do, so I’d appreciate it if someone with much more experience than me would check over my suggestions. Thanks!

p.s. I think I stuffed up the commits. I wanted to make some other changes in 3d88d66 on another branch but they got included here. I hope I’ve reverted them properly.

@hughlilly hughlilly marked this pull request as ready for review September 23, 2022 04:47
@codebytere codebytere self-requested a review September 23, 2022 14:13
@Gu7z
Copy link

Gu7z commented Feb 14, 2023

@hughlilly @codebytere 🆙

@afonsojramos afonsojramos changed the title Settings button toggles between Settings and Notifications feat: settings button toggle between settings and notifications Sep 14, 2023
@afonsojramos
Copy link
Member

Nice QoL PR 👌

@afonsojramos afonsojramos merged commit 43b47a6 into gitify-app:main Sep 14, 2023
5 checks passed
@hughlilly
Copy link
Collaborator Author

Nice QoL PR 👌

Thanks; what does “QoL” mean?

@afonsojramos
Copy link
Member

Nice QoL PR 👌

Thanks; what does “QoL” mean?

Quality of Life 😅

@setchy setchy added the enhancement New feature or enhancement to existing functionality label Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or enhancement to existing functionality
Projects
None yet
6 participants