Skip to content

fix: use enterprise token if hostname of notification is enterprise server #669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 18, 2023

Conversation

p1ass
Copy link
Contributor

@p1ass p1ass commented Oct 16, 2023

Context

Thanks to many contributions released in https://github.com/gitify-app/gitify/releases/tag/v4.4.0, almost issues related to GitHub Enterprise Server have been fixed.
However, an issue about token usage still remains.

Summrary

  • Fix to use an enterprise token if the notification's hostname is enterprise server's name.
    • Current implementation used a github.com token for everything, so some API calls failed with a 401 error.

@p1ass p1ass changed the title fix: use enterprise token if hostname is enterprise server fix: use enterprise token if hostname of notification is enterprise server Oct 16, 2023
@afonsojramos
Copy link
Member

Thanks for the PR!

@afonsojramos afonsojramos merged commit 9150830 into gitify-app:main Oct 18, 2023
@setchy setchy added the bug Something isn't working label Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants