feat: mark repository as done #788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adufr
requested review from
afonsojramos,
bmulholland and
setchy
as code owners
bmulholland
reviewed
Feb 19, 2024
bmulholland
approved these changes
Feb 19, 2024
adufr
force-pushed
the
feat/mark-repository-as-done
branch
from
ce082da
to
0514a43
Compare
bmulholland
approved these changes
Feb 19, 2024
setchy
added
the
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Implements a "Mark repository as done" button, as discussed in #706
Discussion
We had concerns about rate-limiting but according to Github API's the limit is 5000 calls per hour; so I don't think we need to worry about it.
I added a space between repository icons so they are aligned with
NotificationRowicons, but it can be removed if #784 is implemented