Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support discussion state types #827

Merged
merged 10 commits into from Feb 29, 2024
Merged

feat: support discussion state types #827

merged 10 commits into from Feb 29, 2024

Conversation

setchy
Copy link
Member

@setchy setchy commented Feb 26, 2024 •
edited

Closes: #813

Uses the GraphQL API to fetch the Discussion stateReason

Screenshot 2024-02-27 at 6 58 00 AM

@setchy setchy added the enhancement New feature or enhancement to existing functionality label Feb 26, 2024
@setchy setchy marked this pull request as draft February 26, 2024 14:41
@setchy setchy marked this pull request as ready for review February 26, 2024 15:36
@setchy
Copy link
Member Author

setchy commented Feb 26, 2024

In a separate PR, i think it would be wise to move all of this state enrichment logic out of hooks/useNotifications and into a separate file.

bmulholland
bmulholland approved these changes Feb 29, 2024
View reviewed changes
Copy link
Collaborator

@bmulholland bmulholland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good for now -- thanks for the followup ideas!

@setchy setchy merged commit 73d0077 into gitify-app:main Feb 29, 2024
7 checks passed
@setchy setchy deleted the feature/discussion-state-types branch February 29, 2024 16:39
adufr pushed a commit to adufr/gitify that referenced this pull request Mar 25, 2024
@setchy @adufr
feat: support discussion state types (gitify-app#827)
2aebd86 
* feat: support discussion states

* refactor graphql search interface to be generic.

* refactor mocks out
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmulholland bmulholland bmulholland approved these changes

@afonsojramos afonsojramos Awaiting requested review from afonsojramos afonsojramos is a code owner

Assignees
No one assigned
Labels
enhancement New feature or enhancement to existing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feature: support for all discussion types (open, closed, duplicate, outdated)
2 participants
@setchy @bmulholland