-
Notifications
You must be signed in to change notification settings - Fork 276
fix: improve error handling #901
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmulholland
reviewed
Mar 20, 2024
bmulholland
reviewed
Mar 20, 2024
bmulholland
reviewed
Mar 20, 2024
bmulholland
reviewed
Mar 20, 2024
bmulholland
reviewed
Mar 20, 2024
bmulholland
approved these changes
Mar 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some questions and suggestions, but overall this is a lot of hardening, thank you!
adufr
pushed a commit
to adufr/gitify
that referenced
this pull request
Mar 25, 2024
* fix: improve error handling * fix: improve error handling * incorporate pr feedback * Merge remote-tracking branch 'origin/main' into bugfix/improve-error-handling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve handling of attributes which may be null or responses that may be null.
I found some of these causing issues when testing locally