Skip to content

refactor(useNotifications): add types to callbacks #960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 3, 2024
Merged

refactor(useNotifications): add types to callbacks #960

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions src/hooks/useNotifications.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,7 +203,7 @@ export const useNotifications = (colors: boolean): NotificationsState => {
);

const markNotificationRead = useCallback(
async (accounts, id, hostname) => {
async (accounts: AuthState, id: string, hostname: string) => {
setIsFetching(true);

const isEnterprise = isEnterpriseHost(hostname);
Expand Down Expand Up @@ -236,7 +236,7 @@ export const useNotifications = (colors: boolean): NotificationsState => {
);

const markNotificationDone = useCallback(
async (accounts, id, hostname) => {
async (accounts: AuthState, id: string, hostname: string) => {
setIsFetching(true);

const isEnterprise = isEnterpriseHost(hostname);
Expand Down Expand Up @@ -269,7 +269,7 @@ export const useNotifications = (colors: boolean): NotificationsState => {
);

const unsubscribeNotification = useCallback(
async (accounts, id, hostname) => {
async (accounts: AuthState, id: string, hostname: string) => {
setIsFetching(true);

const isEnterprise = isEnterpriseHost(hostname);
Expand All @@ -295,7 +295,7 @@ export const useNotifications = (colors: boolean): NotificationsState => {
);

const markRepoNotifications = useCallback(
async (accounts, repoSlug, hostname) => {
async (accounts: AuthState, repoSlug: string, hostname: string) => {
setIsFetching(true);

const isEnterprise = isEnterpriseHost(hostname);
Expand Down Expand Up @@ -328,7 +328,7 @@ export const useNotifications = (colors: boolean): NotificationsState => {
);

const markRepoNotificationsDone = useCallback(
async (accounts, repoSlug, hostname) => {
async (accounts: AuthState, repoSlug: string, hostname: string) => {
setIsFetching(true);

try {
Expand Down Expand Up @@ -371,7 +371,7 @@ export const useNotifications = (colors: boolean): NotificationsState => {
);

const removeNotificationFromState = useCallback(
(id, hostname) => {
(id: string, hostname: string) => {
const updatedNotifications = removeNotification(
id,
notifications,
Expand Down