Add renderHeader which acts the same as renderFooter but at the top #91
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gitim
reviewed
Feb 28, 2018
src/SortableList.js
Outdated
| @@ -222,10 +229,10 @@ export default class SortableList extends Component { | |||
| if (rowsLayouts) { | |||
| if (horizontal) { | |||
| location.x = nextX; | |||
| nextX += rowsLayouts[key].width; | |||
| nextX += rowsLayouts[key] ? rowsLayouts[key].width : 0; | |||
There was a problem hiding this comment.
Yes - I ran into crashes using react-navigation when this component was not currently on the screen but being updated. I probably could have made a separate PR for that. Let me know if you'd prefer that.
There was a problem hiding this comment.
Moved fix over to #93
gitim
reviewed
Feb 28, 2018
src/SortableList.js
Outdated
| @@ -178,7 +184,7 @@ export default class SortableList extends Component { | |||
| const containerStyle = StyleSheet.flatten([style, {opacity: Number(animated)}]) | |||
| const innerContainerStyle = [ | |||
| styles.rowsContainer, | |||
| horizontal ? {width: contentWidth} : {height: contentHeight}, | |||
| horizontal ? {width: contentWidth} : {height: contentHeight} | |||
|
ok, thanks! will release it soon |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Helps a bit with #89
Fixes #86
Reposted this due to branching change