add support for firefox #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
test steps? |
jdgarcia
reviewed
Jun 22, 2023
scripts/makeManifest.js
Outdated
| makeFirefoxManifest: getMakeManifest(true) | ||
| } | ||
|
|
||
| if (require.main === module && !fs.existsSync()) { |
There was a problem hiding this comment.
is existsSync supposed to have an argument?
|
@jdgarcia added test steps to the contributing |
jdgarcia
approved these changes
Jun 24, 2023
There was a problem hiding this comment.
Works, but I had to manually enable this option to get it to work. Normally installing an extension prompts me to approve/deny permissions. Not sure if it this was because I was running it in dev mode? (from the about:debug page). If that sounds normal then feel free to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds support for firefox. this seems to be the solution until firefox
https://stackoverflow.com/questions/75043889/manifest-v3-background-scripts-service-worker-on-firefox
mozilla/web-ext#2532