GitLens breaks Outline for Python

[rjbruin]

• GitLens Version: 8.4.1
• VSCode Version: 1.24.1
• OS Version: Ubuntu 16.04

Steps to Reproduce:

1. Install Python and GitLens extensions
2. Open Outline view
3. Open Python file in editor. This file should be displayed correctly in Outline.
4. Open another Python file. Now the Outline stays blank.
5. Switching to Search or Debug, then back to Explorer returns the Outline for the open file, but switching to another Python file once again breaks Outline.

I have checked all extensions I'm using, and this occurs only when Python and GitLens are enabled together. The problem does not occur when disabling GitLens.

[eamodio]

I'm pretty sure this is yet another case of https://github.com/DonJayamanne/pythonVSCode/issues/553 which was never fixed as far as I know.

[eamodio]

Opened this on the MS repo: microsoft/vscode-python#2112

[eamodio]

@rjbruin I believe Microsoft released a completely new version of the Python language server (as part of the Python extension) yesterday or today. Can you try it and see if this is still an issue?

[rjbruin]

Unfortunately the problem still persists with vscode-python 2018.7.0 and GitLens 8.5.2.

[eamodio]

Damn :(

[ericsnowcurrently]

@rjbruin, make sure you have "python.jediEnabled": false in your settings. That will activate the new language server.

[rjbruin]

@ericsnowcurrently Thanks!

It seems the issue is connected to the new language server:

• No GitLens + "python.jediEnabled": true: works;
• No GitLens + "python.jediEnabled": false: no file outline will load anymore, and switching out of Explorer and back doesn't return the outline anymore

However, even when disabling the new language server and enabling GitLens the issue remains. Even more confusing, I'm not seeing the same behavior anymore even with the settings of the original issue:

• GitLens + "python.jediEnabled": true (original issue): certain files load without problem, while others don't. Things I've tried to narrow down the differences:
  • Both files are in a repository tracked by GitLens: the one that breaks outline is in our main company repository, the one that works is in a new local repository;
  • Both files have the exact same content and name;
  • Both workspace folders use the same Python interpreter (from virtualenv)

I'm getting kind of lost here. As for the GitLens issue, it seems to have to do with the repository the file is in. If I can do anything to help debug this, please let me know!

[ericsnowcurrently]

@rjbruin, if it's okay, let's discuss this on microsoft/vscode-python#2112. If you want to keep the discussion here I can work with that. :)

[rjbruin]

@ericsnowcurrently I'm fine with that, though I assume you only want to talk about the language server there and leave the GitLens issue here?

[ericsnowcurrently]

Correct. I just don't want to clutter up this issue with stuff that doesn't relate to GitLens. :)