ldap_group_links support

[scphantm]

https://docs.gitlab.com/ee/api/groups.html#add-ldap-group-link

this support would save some time.

[gmessner]

@scphantm
You caught me at a good time, was in the middle of a minor release (4.8.31) and was able to add this. I will leave this issue open. If you could close it after you have verified the functionality I would appreciate it.

In GroupApi:

public void ldapSync(Object groupIdOrPath
public void addLdapGroupLink(Object groupIdOrPath, String cn, AccessLevel groupAccess, String provider)
public void deleteLdapGroupLink(Object groupIdOrPath, String cn)
public void deleteLdapGroupLink(Object groupIdOrPath, String cn, String provider)

[scphantm]

im getting bad request from this, everything works in post man

org.gitlab4j.api.GitLabApiException: Bad Request
            at org.gitlab4j.api.AbstractApi.validate(AbstractApi.java:477)
            at org.gitlab4j.api.AbstractApi.post(AbstractApi.java:209)
            at org.gitlab4j.api.GroupApi.addLdapGroupLink(GroupApi.java:767)

https://github.com/gmessner/gitlab4j-api/blob/master/src/main/java/org/gitlab4j/api/GroupApi.java#L767

this method does return json. This is what i get when i do it with postman

{
    "cn": "git_global_owners",
    "group_access": 50,
    "provider": "ldapmain"
}

reflects back the same data you sent in.

[scphantm]

postman returned an http status of 201 Created

[gmessner]

@scphantm
This has been fixed but untested as I do not have access to GitLab EE. There were two problems related to the group_access level:

1. There was a typo with the form param name, was "group_Access" should be "group_access"
2. It was sending the AccessLevel enum name for group_access not the integer value

Regarding the fact that the call returns the same value sent in, this is not in the documentation so I hesitate to utilize that. The call will be considered successful as long as a 201 is returned.

I've released 4.8.32 with the fixes.

[scphantm]

it worked. Thanks. Ill let you know if we see any problems.

[gmessner]

@scphantm
Thanks for confirming that it worked.