Skip to content

Support New "Job Hook" Hook Renaming #131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 22, 2018

Conversation

armsnyder
Copy link
Contributor

closes #130

Validated by sending a test event from GitLab and it works.

@gmessner
Copy link
Collaborator

@armsnyder
First off thank you for your contribution and this certainly needs to be fixed. The fix looks good other than the name choice for:

 public static final String X_GITLAB_EVENT = "Build Hook";
 public static final String X_GITLAB_EVENT_2 = "Job Hook";

I'd like these to be a bit more descriptive since there is no longer a one to one relationship, could you change these to the following?

 public static final String BUILD_HOOK_X_GITLAB_EVENT = "Build Hook";
 public static final String JOB_HOOK_X_GITLAB_EVENT = "Job Hook";

@armsnyder
Copy link
Contributor Author

Absolutely. I'll throw in a comment as well since even that change doesn't fully explain what's going on.

@gmessner gmessner merged commit 5487b3d into gitlab4j:master Jan 22, 2018
@gmessner
Copy link
Collaborator

@armsnyder
Thanks for making the changes. I've merged the PR, will do a release sometime later this week, have a few other changes that need to go in before the release.

@armsnyder armsnyder deleted the feature/130-job-hook branch January 23, 2018 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Outdated Webhook does not support "Job Hook" rename
2 participants