Skip to content

Conversation

gdubicki
Copy link
Member

@gdubicki gdubicki commented Nov 13, 2022

Support for #388 and #95.

@gdubicki gdubicki had a problem deploying to Integrate Pull Request November 13, 2022 11:27 Failure
@gdubicki gdubicki force-pushed the multiple_approval_rules branch from 7a5337e to d7dbfed Compare November 13, 2022 11:28
@gdubicki gdubicki had a problem deploying to Integrate Pull Request November 13, 2022 11:28 Failure
@gdubicki gdubicki had a problem deploying to Integrate Pull Request November 13, 2022 11:51 Failure
@gdubicki gdubicki had a problem deploying to Integrate Pull Request November 13, 2022 12:25 Failure
@gdubicki gdubicki had a problem deploying to Integrate Pull Request November 13, 2022 12:26 Failure
@gdubicki gdubicki had a problem deploying to Integrate Pull Request November 13, 2022 12:35 Failure
@codecov-commenter
Copy link

codecov-commenter commented Nov 13, 2022

Codecov Report

Merging #435 (61beba2) into main (278f535) will increase coverage by 0.22%.
The diff coverage is 94.44%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #435      +/-   ##
==========================================
+ Coverage   86.93%   87.15%   +0.22%     
==========================================
  Files          65       67       +2     
  Lines        2258     2313      +55     
==========================================
+ Hits         1963     2016      +53     
- Misses        295      297       +2     
Impacted Files Coverage Δ
gitlabform/gitlab/projects.py 68.04% <ø> (-6.58%) ⬇️
...tlabform/processors/multiple_entities_processor.py 96.20% <ø> (-0.19%) ⬇️
gitlabform/processors/defining_keys.py 72.05% <80.00%> (ø)
...labform/gitlab/project_merge_requests_approvals.py 87.50% <87.50%> (ø)
gitlabform/configuration/transform.py 95.33% <98.57%> (+2.31%) ⬆️
gitlabform/constants.py 100.00% <100.00%> (ø)
gitlabform/gitlab/__init__.py 100.00% <100.00%> (ø)
gitlabform/gitlab/branches.py 87.71% <100.00%> (-1.00%) ⬇️
gitlabform/gitlab/core.py 94.81% <100.00%> (+0.15%) ⬆️
gitlabform/processors/abstract_processor.py 89.23% <100.00%> (+0.52%) ⬆️
... and 3 more

@gdubicki gdubicki temporarily deployed to Integrate Pull Request November 13, 2022 13:32 Inactive
@gdubicki gdubicki changed the title Multiple approval rules Add support for multiple approval rules Nov 13, 2022
@gdubicki gdubicki temporarily deployed to Integrate Pull Request November 13, 2022 14:00 Inactive
@gdubicki gdubicki force-pushed the multiple_approval_rules branch from 61beba2 to 39086a4 Compare November 14, 2022 14:44
@gdubicki gdubicki had a problem deploying to Integrate Pull Request November 14, 2022 14:44 Failure
@gdubicki gdubicki marked this pull request as ready for review November 14, 2022 14:46
@gdubicki gdubicki merged commit 951d886 into main Nov 14, 2022
@gdubicki gdubicki deleted the multiple_approval_rules branch November 14, 2022 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants